trafficserver-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jpeach <...@git.apache.org>
Subject [GitHub] trafficserver pull request: TS-4054 Incorrect ink_assert behavior ...
Date Thu, 10 Dec 2015 04:51:25 GMT
Github user jpeach commented on the pull request:

    https://github.com/apache/trafficserver/pull/363#issuecomment-163487199
  
    AFAICT the assertion in ```setup_diagslog``` is correct. I would even go so far as to
make it an ```ink_release_assert``` because otherwise we would leak the global ```diags_log```.
I can see a couple of places where ```diags_log``` is deleted before ```setup_diagslog```
is called.
    
    The best way to fix this IMHO is to not deal with ```drags_log``` at all in ```setup_diagslog```.
The pattern that this code should do is:
    
        if (setup_diagslog(blf)) {
            delete drags_log;
            diags_log = blf;
        }
    
    ```setup_diagslog``` can be changed from a member function to a local static function,
and you can remove all mentions of ```diags_log``` from it.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message