trafficserver-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zwoop <...@git.apache.org>
Subject [GitHub] trafficserver pull request: TS-4030: Allow parent selection to ign...
Date Tue, 08 Dec 2015 19:58:45 GMT
Github user zwoop commented on the pull request:

    https://github.com/apache/trafficserver/pull/369#issuecomment-162997233
  
    This mostly looks good, except in
    
        +char *
        +ParentRecord::getHashPath(RequestData *rdata, size_t *path_len)
        +{
    
    
    I think, but not 100% sure, that this effectively always strips the query parameter. My
reasoning for this is that this ought to always just return the path (without the query params):
    
        path = const_cast<char *>(hrdata->hdr->path_get(&plen));
    
    
    Right?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message