trafficserver-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From SolidWallOfCode <...@git.apache.org>
Subject [GitHub] trafficserver pull request: remove alloc_cache from NetAccept
Date Mon, 07 Dec 2015 15:34:12 GMT
Github user SolidWallOfCode commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/366#discussion_r46833574
  
    --- Diff: iocore/net/UnixNetAccept.cc ---
    @@ -112,9 +106,17 @@ net_accept(NetAccept *na, void *ep, bool blockable)
           count = res;
           goto Ldone;
         }
    +    
    +    vc = (UnixNetVConnection *)na->getNetProcessor()->allocate_vc(e->ethread);
    +    if (!vc) {
    +      con.close();
    +      goto Ldone;
    +    }
    +    
         count++;
    -    na->alloc_cache = NULL;
    -
    +    NET_SUM_GLOBAL_DYN_STAT(net_connections_currently_open_stat, 1);
    +    vc->id = net_next_connection_number();
    +    vc->con = con;
    --- End diff --
    
    I think `vc->con.move(con)` would be better here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message