trafficserver-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From maskit <...@git.apache.org>
Subject [GitHub] trafficserver pull request: TS-4018: Use HPACK huffman encoding al...
Date Mon, 07 Dec 2015 01:17:16 GMT
Github user maskit commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/362#discussion_r46780362
  
    --- Diff: proxy/http2/HPACK.cc ---
    @@ -332,18 +332,41 @@ int64_t
     encode_string(uint8_t *buf_start, const uint8_t *buf_end, const char *value, size_t value_len)
     {
       uint8_t *p = buf_start;
    +  bool use_huffman = true;
    --- End diff --
    
    I left the flag for further use. There are some cases that plain text is shorter than
huffman encoded data, and the codes for both cases would be used when we found a smart way
to switch the encoding.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message