trafficserver-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From danobi <...@git.apache.org>
Subject [GitHub] trafficserver pull request: TS-4054 Incorrect ink_assert behavior ...
Date Fri, 04 Dec 2015 17:58:00 GMT
Github user danobi commented on the pull request:

    https://github.com/apache/trafficserver/pull/363#issuecomment-162035450
  
    It is marked private. Would your suggestion still be to nest everything inside the `if
(blf != NULL)`? I don't see any reason to keep `ink_assert(diags_log == NULL)` since the condition
is always true b/c in the constructor we explicitly set `diags_log` to NULL. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message