trafficserver-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From SolidWallOfCode <...@git.apache.org>
Subject [GitHub] trafficserver pull request: TS-4054 Incorrect ink_assert behavior ...
Date Fri, 04 Dec 2015 17:51:08 GMT
Github user SolidWallOfCode commented on the pull request:

    https://github.com/apache/trafficserver/pull/363#issuecomment-162033850
  
    Is `setup_diagslog` marked `private`? If not, it should be if it's called only from the
constructor. Otherwise dropping the assert seems reasonable.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message