trafficserver-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From SolidWallOfCode <...@git.apache.org>
Subject [GitHub] trafficserver pull request: TS-4054 Incorrect ink_assert behavior ...
Date Fri, 04 Dec 2015 17:48:51 GMT
Github user SolidWallOfCode commented on the pull request:

    https://github.com/apache/trafficserver/pull/363#issuecomment-162033316
  
    Yes. Looking at the code it seems the better choice would be to keep the assert and move
it after the `NULL` check on `blf`. I would be tempted to, rather than return there, reverse
the check ( `blf != NULL` ) and enclose the rest of the function in that clause, including
the assert.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message