trafficserver-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zwoop <...@git.apache.org>
Subject [GitHub] trafficserver pull request: TS-4050 - Trafficserver is crashing wh...
Date Thu, 03 Dec 2015 23:44:02 GMT
Github user zwoop commented on the pull request:

    https://github.com/apache/trafficserver/pull/361#issuecomment-161826127
  
    Much better!
    
    I'll have to check / read the code more thoroughly, but are you sure this isn't now leaking
the object when the freelist is empty?
    
         _freelist.splice(_freelist.begin(), _list, map_it->second);
    +        // Check if list is not empty
    +        if (!_list.empty()) {
    +          _freelist.splice(_freelist.begin(), _list, map_it->second);
    +        }



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message