trafficserver-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zizhong <...@git.apache.org>
Subject [GitHub] trafficserver pull request: TS-3960: traffic_line -x doesn't reloa...
Date Wed, 02 Dec 2015 15:47:03 GMT
Github user zizhong commented on the pull request:

    https://github.com/apache/trafficserver/pull/301#issuecomment-161340071
  
    @jpeach you are right. Coping SSL related files can cause secure issues. In my opinion,
all the child files should not be copied. what do you think handling it in this way?
    ```FileManager::fileChanged``` is the function that directly triggers notifications. ```Rollback::internalUpdate```
backs up files, maintains the correct version and then calls ```fileChanged``` .
    A new commit has been pushed on your advice. Would you mind taking another look? Thanks
a lot!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message