trafficserver-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ushachar <...@git.apache.org>
Subject [GitHub] trafficserver pull request: TS-3072: Debug logging for single conn...
Date Wed, 02 Dec 2015 07:20:05 GMT
Github user ushachar commented on the pull request:

    https://github.com/apache/trafficserver/pull/350#issuecomment-161205132
  
    To quote our own docs (under Admin Guide/Plugins):
    """
    One of the key features of Apache Traffic Server™ is its modularity. Features that aren’t
needed in the core simply aren’t there. This helps to provide an additional guarantee that
our core can remain fast by concentrating on the things that we always provide: caching and
proxying.
    """
    I'd add that keeping things out of the core also makes it easier to understand, verify
and debug.
    
    The way I see it - Logic on when to enable debugging on a transaction/session can be arbitrarily
complex. I'm sure everyone on this thread can see the use of enabling debugs based on things
like cipher suites, TLS protocol version, destination IPs. Even when relying only on source
IPs, you might want to enable for only one in ten connections to cut the logging volume.
    Our (badly named :-) ) header_rewrite plugin can easily be adjusted to support such logic.
    (Personally - my trigger to enable debugging is often determined in an external process
that does policy matching)
    
    @djcarlin - This being implemented in a plugin doesn't mean you'd have to restart ATS
to use it -- The plugin would be loaded by default and you could enable/disable debugging
by modifying it's configuration.
    (You could even talk to it directly via traffic_line using @SolidWallOfCode latest work
on TS-4032)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message