trafficserver-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jpeach <...@git.apache.org>
Subject [GitHub] trafficserver pull request: fix rpath flags when multiple "--with-...
Date Wed, 02 Dec 2015 05:50:47 GMT
Github user jpeach commented on the pull request:

    https://github.com/apache/trafficserver/pull/324#issuecomment-161188083
  
    This is getting closer. Please rebase your changes onto latest master and force push the
branch to refresh.
    
    There are a number of places that still need to be updated to use ```TS_ADDTO_RPATH```:
    
        $ grep LIBTOOL_LINK_FLAGS build./
        common.m4:  TS_ADDTO(LIBTOOL_LINK_FLAGS, [-Wl,-rpath -Wl,$1])
        jemalloc.m4:    TS_ADDTO(LIBTOOL_LINK_FLAGS, [-R${jemalloc_ldflags}])
        lzma.m4:    TS_ADDTO(LIBTOOL_LINK_FLAGS, [-R${lzma_ldflags}])
        pcre.m4:    TS_ADDTO(LIBTOOL_LINK_FLAGS, [-R${pcre_ldflags}])
        xml.m4:        TS_ADDTO(LIBTOOL_LINK_FLAGS, [-R${libxml2_ldflags}])
        xml.m4:    TS_ADDTO(LIBTOOL_LINK_FLAGS, [-R${expat_ldflags}])
    
    Notice that these all use the ```-R/path``` syntax. This is because the portable syntax
for specifying the RPATH is ```-Wl,-rpath -Wl,/path```. The ```-Wl,-rpath=/path``` syntax
appears to be specific to the GNU linker (at least it is not supported by the OS X linker).
When I tried the portable syntax, ```TS_ADDTO``` doesn't do the right thing (it splits on
whitespace). You end up with something like this:
    
            LIBTOOL_LINK_FLAGS: -Wl,-rpath -Wl,/usr/local/lib -Wl,/opt/jpeach/lib
    
    Finally, you need to append ```$RPATH``` in the main ```configure.ac``` since it is possible
for ```TS_ADDTO_RPATH``` to never get called.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message