Mailing-List: contact dev-help@trafficserver.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@trafficserver.apache.org
From: SolidWallOfCode <git@git.apache.org>
To: dev@trafficserver.apache.org
Reply-To: dev@trafficserver.apache.org
References: <git-pr-240-trafficserver@git.apache.org>
In-Reply-To: <git-pr-240-trafficserver@git.apache.org>
Subject: [GitHub] trafficserver pull request: Maintain and use a mapping of
 hostname...
Content-Type: text/plain
Message-Id: <20150702204104.20E25E367A@git1-us-west.apache.org>
Date: Thu,  2 Jul 2015 20:41:04 +0000 (UTC)

Github user SolidWallOfCode commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/240#discussion_r33820528
  
    --- Diff: iocore/hostdb/P_HostDBProcessor.h ---
    @@ -190,6 +190,14 @@ extern RecRawStatBlock *hostdb_rsb;
     #define HOSTDB_DECREMENT_THREAD_DYN_STAT(_s, _t) RecIncrRawStatSum(hostdb_rsb, _t, (int)_s, -1);
     
     
    +struct CmpConstBuffferCaseInsensitive {
    +  bool operator()(ts::ConstBuffer a, ts::ConstBuffer b) { return ptr_len_casecmp(a._ptr, a._size, b._ptr, b._size) < 0;}
    +};
    +// A to hold a ref-counted map
    +struct RefCountedHostsFileMap : public RefCountObj {
    +  std::map<ts::ConstBuffer, IpAddr, CmpConstBuffferCaseInsensitive> hosts_file_map;
    --- End diff --
    
    You'll probably want `typedef std::map<ts::ConstBuffer, IpAddr, CmpConstBufferCaseInsensitive> MapType;' here. It's a handy typedef.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---