trafficserver-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sudheerv <...@git.apache.org>
Subject [GitHub] trafficserver pull request: TS-1007: SSLN Close called before TXN ...
Date Mon, 13 Jul 2015 22:39:24 GMT
Github user sudheerv commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/249#discussion_r34520227
  
    --- Diff: proxy/http/HttpSM.cc ---
    @@ -6560,6 +6559,12 @@ HttpSM::kill_this()
       reentrancy_count--;
       ink_release_assert(reentrancy_count == 0);
     
    +  // Delay the close of the user agent session, so the close session
    +  // occurs after the close transaction
    +  if (ua_session != NULL)
    --- End diff --
    
    Not what I see for non-VC errors (in fact, there really is no reason to close the connection
on non-VC errors).
    
    For example, https://github.com/apache/trafficserver/blob/master/proxy/http/HttpSM.cc#L1424


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message