trafficserver-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ushachar <...@git.apache.org>
Subject [GitHub] trafficserver pull request: Ts 3534
Date Thu, 09 Jul 2015 12:31:48 GMT
Github user ushachar commented on the pull request:

    https://github.com/apache/trafficserver/pull/194#issuecomment-119945084
  
    I still think all the SSLNetVConnection::computeSSLTrace() logic should be moved into
plugin space - even if not extending TSHttpSsnDebugSet and keeping this as a standalone option.
    Also - how about a macro to unify lines like these:
    """
    Debug("ssl.error", "SSLNetVConnection::sslClientHandShakeEvent, SSL_ERROR_WANT_READ");
    TraceIn(trace, get_remote_addr(), get_remote_port(),  "SSL client handshake ERROR_WANT_READ");
    """


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message