trafficserver-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shinrich <...@git.apache.org>
Subject [GitHub] trafficserver pull request: Ts 3559
Date Tue, 07 Jul 2015 15:10:26 GMT
Github user shinrich commented on the pull request:

    https://github.com/apache/trafficserver/pull/232#issuecomment-119234117
  
    Two comments.  One is a minor style comment about the functions you added to SSLInternal.c.
 Ideally the API for the functions in there should be the same as the API for the functions
that will be in openssl 1.1.  So when you do the autoconf testing, they just swap out for
the real ones.
    
    The other comment is about the ticket cache map.  I agree with James, that sharing the
cache table implementation would be nice.  Given the size of things, maybe not worth the effort.
 My bigger concern is making sure that the table is thread safe.  In a caching environment,
transient errors are ok, but structural errors from multiple writers are concerning. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message