trafficserver-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shinrich <...@git.apache.org>
Subject [GitHub] trafficserver pull request: TS-3742: ATS incorrectly advertises TL...
Date Tue, 07 Jul 2015 11:05:52 GMT
Github user shinrich commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/241#discussion_r34028929
  
    --- Diff: iocore/net/SSLUtils.cc ---
    @@ -308,8 +308,10 @@ set_context_cert(SSL *ssl)
       if (ctx != NULL) {
         SSL_set_SSL_CTX(ssl, ctx);
     #if HAVE_OPENSSL_SESSION_TICKETS
    -    // Reset the ticket callback if needed
    -    SSL_CTX_set_tlsext_ticket_key_cb(ctx, ssl_callback_session_ticket);
    +    if (SSL_CTX_get_options(ctx) & SSL_OP_NO_TICKET) {
    --- End diff --
    
    That does seem backwards, doesn't it.  Will track it down.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message