trafficserver-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bgaff <...@git.apache.org>
Subject [GitHub] trafficserver pull request: TS-3742: ATS incorrectly advertises TL...
Date Tue, 07 Jul 2015 01:28:10 GMT
Github user bgaff commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/241#discussion_r34001015
  
    --- Diff: iocore/net/SSLUtils.cc ---
    @@ -308,8 +308,10 @@ set_context_cert(SSL *ssl)
       if (ctx != NULL) {
         SSL_set_SSL_CTX(ssl, ctx);
     #if HAVE_OPENSSL_SESSION_TICKETS
    -    // Reset the ticket callback if needed
    -    SSL_CTX_set_tlsext_ticket_key_cb(ctx, ssl_callback_session_ticket);
    +    if (SSL_CTX_get_options(ctx) & SSL_OP_NO_TICKET) {
    --- End diff --
    
    I'm not sure this is correct:
    
    SSL_OP_NO_TICKET
    Normally clients and servers will, where possible, transparently make use of RFC4507bis
tickets for stateless session resumption.
    
    If this option is set this functionality is disabled and tickets will not be used by clients
or servers.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message