trafficserver-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From SolidWallOfCode <...@git.apache.org>
Subject [GitHub] trafficserver pull request: Maintain and use a mapping of hostname...
Date Thu, 02 Jul 2015 20:44:23 GMT
Github user SolidWallOfCode commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/240#discussion_r33820816
  
    --- Diff: iocore/hostdb/HostDB.cc ---
    @@ -2565,18 +2568,9 @@ int HostDBFileUpdateActive = 0;
     // Contents of the host file. We keep this around because other data
     // points in to it (to minimize allocations).
     ats_scoped_str HostFileText;
    --- End diff --
    
    This needs to be moved to the host file map, as it needs to have *exactly* the same life
time as that map (as all of the `ConstBuffer` items are pointing in to this buffer).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message