trafficserver-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Thomas Jackson <jacksontj...@gmail.com>
Subject Re: git submodule issues
Date Wed, 16 Apr 2014 00:26:00 GMT
I'd prefer to keep it as a submodule because it will make porting fixes etc
significantly easier. Do we have any specifics about the problems in the
build systems? I use git submodules for some tooling internally-- so I
might be able to give a hand. The submodule stuff has been there for a
while so I doubt its a problem with the version of git-- more likely the
commands in the build scripts aren't running the appropriate updates etc.






On Tue, Apr 15, 2014 at 4:51 PM, Phil Sorber <sorber@apache.org> wrote:

> On Tue, Apr 15, 2014 at 4:44 PM, Leif Hedstrom <zwoop@apache.org> wrote:
>
> > Hi all,
> >
> > we added LuaJIT as a submodule, and it seems to be breaking in odd ways
> on
> > the build systems. Some of them handles it, others do not. Presumably
> > different git versions? E.g. it works on CentOS5, but not CentOS6, etc.
> etc.
> >
> > How do we feel about simply just “importing” this into the tree, and deal
> > with merging in upstream changes as necessary ? Unless someone else has a
> > solution to this, I think that’s what we’ll have to do.
> >
>
> I know some people have issues with that, and it's not ideal, but I am +1
> on it. In my experience, git submodule does not always work as expected. I
> dunno if it's not heavily used/tested, or flawed design. If we plan to
> stick with one version anyway, it shouldn't be much of an issue and if
> someone figures out what we are doing wrong with submodule we can always go
> back to it in the future.
>
>
> >
> > Cheers,
> >
> > — Leif
> >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message