Mailing-List: contact dev-help@trafficserver.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@trafficserver.apache.org
Received-SPF: pass (athena.apache.org: local policy)
Date: Wed, 4 Dec 2013 18:29:44 +0000 (UTC)
From: Igor =?utf-8?Q?Gali=C4=87?= <i.galic@brainsware.org>
To: dev@trafficserver.apache.org
Message-ID: <1163653851.275968.1386181784547.JavaMail.zimbra@brainsware.org>
In-Reply-To: <27BCBE90-D17E-4E37-8169-42EC57845E66@apache.org>
References: <dcfd28e862934108a4ee045750e8d21d@git.apache.org>
 <075756EC-6335-4C01-8BDE-55BA9E468DD3@apache.org>
 <CABF6JR1aLxBG5j-_DaCZuSWZOKex4ixfr0ugmXdzG8KWZB1zDQ@mail.gmail.com>
 <27BCBE90-D17E-4E37-8169-42EC57845E66@apache.org>
Subject: Re: git commit: TS-1815: Add the file descriptor number to ET_AIO
 thread names
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Thread-Topic: git commit: TS-1815: Add the file descriptor number to ET_AIO
 thread names
Thread-Index: P8nZeKN+NBA6qs/+dtaiuYjuUt2wyw==


----- Original Message -----
> On Dec 4, 2013, at 8:21 AM, Phil Sorber <sorber@apache.org> wrote:
>=20
> > On Wed, Dec 4, 2013 at 9:13 AM, James Peach <jpeach@apache.org> wrote:
> >=20
> >> On Dec 3, 2013, at 10:09 PM, sorber@apache.org wrote:
> >>=20
> >>> Updated Branches:
> >>> refs/heads/master 0022a5467 -> 52b6227cd
> >>>=20
> >>>=20
> >>> TS-1815: Add the file descriptor number to ET_AIO thread names
> >>>=20
> >>>=20
> >>> Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
> >>> Commit:
> >> http://git-wip-us.apache.org/repos/asf/trafficserver/commit/52b6227c
> >>> Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/52b62=
27c
> >>> Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/52b62=
27c
> >>>=20
> >>> Branch: refs/heads/master
> >>> Commit: 52b6227cd22f53a44ba38761d662dec9b22e6cfa
> >>> Parents: 0022a54
> >>> Author: Phil Sorber <sorber@apache.org>
> >>> Authored: Tue Dec 3 23:08:55 2013 -0700
> >>> Committer: Phil Sorber <sorber@apache.org>
> >>> Committed: Tue Dec 3 23:08:55 2013 -0700
> >>>=20
> >>> ---------------------------------------------------------------------=
-
> >>> CHANGES           | 3 ++-
> >>> iocore/aio/AIO.cc | 2 +-
> >>> 2 files changed, 3 insertions(+), 2 deletions(-)
> >>> ---------------------------------------------------------------------=
-
> >>>=20
> >>>=20
> >>>=20
> >> http://git-wip-us.apache.org/repos/asf/trafficserver/blob/52b6227c/CHA=
NGES
> >>> ---------------------------------------------------------------------=
-
> >>> diff --git a/CHANGES b/CHANGES
> >>> index e8fdc32..52d15f9 100644
> >>> --- a/CHANGES
> >>> +++ b/CHANGES
> >>> @@ -2,7 +2,8 @@
> >>> Changes with Apache Traffic Server 4.2.0
> >>>=20
> >>>=20
> >>> -  *) [TS-1815] Add thread number and port to accept thread name
> >>> +  *) [TS-1815] Add thread number and port to accept thread name and
> >>> +   add the file descriptor number to the ET_AIO thread names
> >>>=20
> >>>  *) [TS-2415] Use standard continuations to release UrlRewrite object=
s.
> >>>=20
> >>>=20
> >>>=20
> >> http://git-wip-us.apache.org/repos/asf/trafficserver/blob/52b6227c/ioc=
ore/aio/AIO.cc
> >>> ---------------------------------------------------------------------=
-
> >>> diff --git a/iocore/aio/AIO.cc b/iocore/aio/AIO.cc
> >>> index 9f08e9e..a0fd386 100644
> >>> --- a/iocore/aio/AIO.cc
> >>> +++ b/iocore/aio/AIO.cc
> >>> @@ -255,7 +255,7 @@ aio_init_fildes(int fildes, int fromAPI =3D 0)
> >>>      thr_info =3D new AIOThreadInfo(request, 1);
> >>>    else
> >>>      thr_info =3D new AIOThreadInfo(request, 0);
> >>> -    snprintf(thr_name, MAX_THREAD_NAME_LENGTH, "[ET_AIO %d]", i);
> >>> +    snprintf(thr_name, MAX_THREAD_NAME_LENGTH, "[ET_AIO %d-%d]",
> >> fildes, i);
> >>=20
> >> Why is '-' the separator for AIO threads, but ':' the separator for ne=
t
> >> threads? Also, this would be usefully documented in the man page ;)
> >>=20
> >>=20
> > I like : for ports. If it's not a port, : might be confusing. It's a mi=
nor
> > change and I am not married to it. I think we just need *something* the=
re.
>=20
> I'd prefer ":" for both just to be consistent.

Technically, this changes our API/ABI

if someone out there has tools based on this, they will break.

=20
> > Is there a particular man page you had in mind? I will update.
>=20
> Maybe the traffic_server man page?
>=20
> J
>=20

++ i=20
Igor Gali=C4=87

Tel: +43 (0) 664 886 22 883
Mail: i.galic@brainsware.org
URL: http://brainsware.org/
GPG: 8716 7A9F 989B ABD5 100F  4008 F266 55D6 2998 1641