trafficserver-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Yunkai Zhang <yunkai...@gmail.com>
Subject Re: git commit: TS-1678: Simplify register_record()
Date Fri, 01 Feb 2013 19:02:04 GMT
在 2013年2月2日星期六,Igor Galić 写道:

> On Friday, February 01, 2013 04:36:37 PM jpeach@apache.org <javascript:;>wrote:
> > Updated Branches:
> >   refs/heads/master baca4d2b7 -> 5f93bc50f
> >
> >
> > TS-1678: Simplify register_record()
> >
> > 'release_record_lock' parameter to register_record() is unnecessarily
> > complicated and the lock release is dangerous. Let's simplify it
>
> I'm all for removing code but would you care to explain why "the lock
> release
> is dangerous" ?
>
>
Releasing a lock before acquiring it is a bad behavior.

Although there is a reference count, but if the count > 0, the releasing
operation will decrease it unsafely.



> -- i
>


-- 
Yunkai Zhang
Work at Taobao

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message