trafficserver-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bc...@apache.org
Subject git commit: TS-2837: Dangling pointer in URLImpl which may cause core dump Reviewed: Bryan Call
Date Wed, 28 May 2014 22:12:51 GMT
Repository: trafficserver
Updated Branches:
  refs/heads/master b0ed3daa8 -> f4e9fd619


TS-2837: Dangling pointer in URLImpl which may cause core dump
Reviewed: Bryan Call


Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/f4e9fd61
Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/f4e9fd61
Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/f4e9fd61

Branch: refs/heads/master
Commit: f4e9fd61953de3647351aa0ccb2775091cdbf701
Parents: b0ed3da
Author: Kang Li <kangli@yahoo-inc.com>
Authored: Wed May 28 15:11:48 2014 -0700
Committer: Bryan Call <bcall@apache.org>
Committed: Wed May 28 15:11:48 2014 -0700

----------------------------------------------------------------------
 CHANGES           | 2 ++
 proxy/hdrs/URL.cc | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/trafficserver/blob/f4e9fd61/CHANGES
----------------------------------------------------------------------
diff --git a/CHANGES b/CHANGES
index 84a8ccc..134d5cd 100644
--- a/CHANGES
+++ b/CHANGES
@@ -1,6 +1,8 @@
                                                          -*- coding: utf-8 -*-
 Changes with Apache Traffic Server 5.0.0
 
+  *) [TS-2837] Dangling pointer in URLImpl which may cause core dump
+
   *) [TS-2842] Can't set SPDY inactivity timeout with traffic_line
 
   *) [TS-2618] IOBufferBlock::realloc()'s bounds check is wrong.

http://git-wip-us.apache.org/repos/asf/trafficserver/blob/f4e9fd61/proxy/hdrs/URL.cc
----------------------------------------------------------------------
diff --git a/proxy/hdrs/URL.cc b/proxy/hdrs/URL.cc
index e9b64cd..6a6195f 100644
--- a/proxy/hdrs/URL.cc
+++ b/proxy/hdrs/URL.cc
@@ -356,7 +356,7 @@ URLImpl::move_strings(HdrStrHeap * new_heap)
   HDR_MOVE_STR(m_ptr_params, m_len_params);
   HDR_MOVE_STR(m_ptr_query, m_len_query);
   HDR_MOVE_STR(m_ptr_fragment, m_len_fragment);
-//    HDR_MOVE_STR(m_ptr_printed_string, m_len_printed_string);
+  HDR_MOVE_STR(m_ptr_printed_string, m_len_printed_string);
 }
 
 size_t


Mime
View raw message