trafficserver-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zw...@apache.org
Subject [1/2] git commit: TS-2254 On ARM arch, ink_atomic_increment returns wrong value
Date Sat, 12 Oct 2013 15:27:54 GMT
Updated Branches:
  refs/heads/master 4c5fbfa06 -> 898d0a558


TS-2254 On ARM arch, ink_atomic_increment returns wrong value

It should return the old value, before the increment. This is
consistent with how the other ink_atomic_increment implementation
works.

Review: leif


Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/a3d98482
Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/a3d98482
Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/a3d98482

Branch: refs/heads/master
Commit: a3d98482c1ad8b81494efae5222dd2fff4504a3c
Parents: 4c5fbfa
Author: Yu Qing <happy_fish100 at yahoo dot com dot cn>
Authored: Sat Oct 12 09:25:49 2013 -0600
Committer: Leif Hedstrom <zwoop@apache.org>
Committed: Sat Oct 12 09:25:49 2013 -0600

----------------------------------------------------------------------
 lib/ts/ink_atomic.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/trafficserver/blob/a3d98482/lib/ts/ink_atomic.h
----------------------------------------------------------------------
diff --git a/lib/ts/ink_atomic.h b/lib/ts/ink_atomic.h
index 9267271..51d87c0 100644
--- a/lib/ts/ink_atomic.h
+++ b/lib/ts/ink_atomic.h
@@ -202,7 +202,7 @@ ink_atomic_increment<int64_t>(pvint64 mem, int64_t value) {
   curr = *mem;
   *mem = curr + value;
   ink_mutex_release(&__global_death);
-  return curr + value;
+  return curr;
 }
 
 template<>


Mime
View raw message