trafficserver-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From z..@apache.org
Subject git commit: TS-1151: cop may crash due to uninitialized pointer val
Date Wed, 10 Jul 2013 07:07:26 GMT
Updated Branches:
  refs/heads/master d230caedc -> 5d89a9c03


TS-1151: cop may crash due to uninitialized pointer val

Signed-off-by: Zhao Yongming <ming.zym@gmail.com>


Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/5d89a9c0
Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/5d89a9c0
Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/5d89a9c0

Branch: refs/heads/master
Commit: 5d89a9c033f57c8e3c22e0afda02fb168441e4cb
Parents: d230cae
Author: quehan <quehan@taobao.com>
Authored: Wed Jun 26 15:36:28 2013 +0800
Committer: Zhao Yongming <ming.zym@gmail.com>
Committed: Wed Jul 10 15:06:44 2013 +0800

----------------------------------------------------------------------
 CHANGES           | 2 ++
 cop/TrafficCop.cc | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/trafficserver/blob/5d89a9c0/CHANGES
----------------------------------------------------------------------
diff --git a/CHANGES b/CHANGES
index 12b3133..c220229 100644
--- a/CHANGES
+++ b/CHANGES
@@ -2,6 +2,8 @@
 Changes with Apache Traffic Server 3.3.5
 
 
+  *) [TS-1151] cop may crash due to uninitialized pointer val
+
   *) [TS-2013] Install the tspush script.
 
   *) [TS-2012] Use standard C++11 containers in logstats.

http://git-wip-us.apache.org/repos/asf/trafficserver/blob/5d89a9c0/cop/TrafficCop.cc
----------------------------------------------------------------------
diff --git a/cop/TrafficCop.cc b/cop/TrafficCop.cc
index bdac1ec..2858b41 100644
--- a/cop/TrafficCop.cc
+++ b/cop/TrafficCop.cc
@@ -1195,7 +1195,7 @@ test_rs_port()
 static int
 test_mgmt_cli_port()
 {
-  TSString val;
+  TSString val = NULL;
   int ret = 0;
 
   if (TSRecordGetString("proxy.config.manager_binary", &val) !=  TS_ERR_OKAY) {


Mime
View raw message