trafficserver-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zw...@apache.org
Subject git commit: TS-1820 More UNUSED fixes, with WCCP build on
Date Sat, 20 Apr 2013 14:47:22 GMT
Updated Branches:
  refs/heads/master cd1c66fab -> e32f83e5c


TS-1820 More UNUSED fixes, with WCCP build on


Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/e32f83e5
Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/e32f83e5
Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/e32f83e5

Branch: refs/heads/master
Commit: e32f83e5c0bd0564cec0cf80313ffa6e17998672
Parents: cd1c66f
Author: Leif Hedstrom <zwoop@apache.org>
Authored: Sat Apr 20 08:47:15 2013 -0600
Committer: Leif Hedstrom <zwoop@apache.org>
Committed: Sat Apr 20 08:47:15 2013 -0600

----------------------------------------------------------------------
 configure.ac                              |    2 +-
 lib/tsconfig/TsConfigGrammar.y            |    3 ++-
 lib/tsconfig/TsErrataUtil.cc              |    1 +
 lib/tsconfig/test-tsconfig.cc             |    2 +-
 lib/wccp/WccpEndPoint.cc                  |   10 +++++-----
 lib/wccp/WccpMsg.cc                       |    4 ++--
 lib/wccp/WccpStatic.cc                    |    1 +
 mgmt/cli/CliCreateCommands.cc             |    2 +-
 plugins/experimental/esi/lib/Variables.cc |    2 +-
 9 files changed, 15 insertions(+), 12 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/trafficserver/blob/e32f83e5/configure.ac
----------------------------------------------------------------------
diff --git a/configure.ac b/configure.ac
index 8f8b546..15d6e56 100644
--- a/configure.ac
+++ b/configure.ac
@@ -697,7 +697,7 @@ case $host_os in
     *) # gcc
       # This is useful for finding odd conversions
       #    common_opt="-pipe -Wall -Werror -Wconversion -Wno-sign-conversion"
-      common_opt="-pipe -Wall -Werror -Wunused-parameter"
+      common_opt="-pipe -Wall -Werror -Wno-error=unused-parameter -Wunused-parameter"
       debug_opt="-ggdb3 $common_opt"
       release_opt="-g $common_opt $optimizing_flags -feliminate-unused-debug-symbols -fno-strict-aliasing"
       cxx_opt="-Wno-invalid-offsetof"

http://git-wip-us.apache.org/repos/asf/trafficserver/blob/e32f83e5/lib/tsconfig/TsConfigGrammar.y
----------------------------------------------------------------------
diff --git a/lib/tsconfig/TsConfigGrammar.y b/lib/tsconfig/TsConfigGrammar.y
index 0514fd0..2eec64d 100644
--- a/lib/tsconfig/TsConfigGrammar.y
+++ b/lib/tsconfig/TsConfigGrammar.y
@@ -32,6 +32,7 @@
 # define YYFREE free
 
 # include "TsConfigParseEvents.h"
+# include "ink_defs.h"
 
 // Types we need for the lexer.
 typedef void* yyscan_t;
@@ -48,7 +49,7 @@ extern int tsconfiglex(YYSTYPE* yylval, yyscan_t lexer);
   }
 
 int tsconfigerror(
-  yyscan_t lexer,
+  yyscan_t lexer ATS_UNUSED,
   struct TsConfigHandlers* handlers,
   char const* text
 ) {

http://git-wip-us.apache.org/repos/asf/trafficserver/blob/e32f83e5/lib/tsconfig/TsErrataUtil.cc
----------------------------------------------------------------------
diff --git a/lib/tsconfig/TsErrataUtil.cc b/lib/tsconfig/TsErrataUtil.cc
index 8b0602d..bbb879e 100644
--- a/lib/tsconfig/TsErrataUtil.cc
+++ b/lib/tsconfig/TsErrataUtil.cc
@@ -29,6 +29,7 @@
 # include <errno.h>
 # include <TsErrataUtil.h>
 # include "ink_string.h"
+# include "ink_defs.h"
 
 namespace ts { namespace msg {
 

http://git-wip-us.apache.org/repos/asf/trafficserver/blob/e32f83e5/lib/tsconfig/test-tsconfig.cc
----------------------------------------------------------------------
diff --git a/lib/tsconfig/test-tsconfig.cc b/lib/tsconfig/test-tsconfig.cc
index b07d232..5995e9f 100644
--- a/lib/tsconfig/test-tsconfig.cc
+++ b/lib/tsconfig/test-tsconfig.cc
@@ -31,7 +31,7 @@ inline std::ostream& operator << ( std::ostream& s, ts::ConstBuffer
const& b ) {
   return s;
 }
 
-int main(int argc, char ** argv) {
+int main(int /* argc ATS_UNUSED */, char **/* argv ATS_UNUSED */) {
   printf("Testing TsConfig\n");
   ts::Rv<Configuration> cv = Configuration::loadFromPath("test-1.tsconfig");
   if (cv.isOK()) {

http://git-wip-us.apache.org/repos/asf/trafficserver/blob/e32f83e5/lib/wccp/WccpEndPoint.cc
----------------------------------------------------------------------
diff --git a/lib/wccp/WccpEndPoint.cc b/lib/wccp/WccpEndPoint.cc
index 6b5037b..4d759eb 100644
--- a/lib/wccp/WccpEndPoint.cc
+++ b/lib/wccp/WccpEndPoint.cc
@@ -242,15 +242,15 @@ Impl::handleHereIAm(IpHeader const&, ts::Buffer const&) {
   return log(LVL_INFO, "Unanticipated WCCP2_HERE_I_AM message ignored");
 }
 ts::Errata
-Impl::handleISeeYou(IpHeader const&, ts::Buffer const& data) {
+Impl::handleISeeYou(IpHeader const&, ts::Buffer const& /* data ATS_UNUSED */) {
   return log(LVL_INFO, "Unanticipated WCCP2_I_SEE_YOU message ignored.");
 }
 ts::Errata
-Impl::handleRedirectAssign(IpHeader const&, ts::Buffer const& data) {
+Impl::handleRedirectAssign(IpHeader const&, ts::Buffer const& /* data ATS_UNUSED
*/) {
   return log(LVL_INFO, "Unanticipated WCCP2_REDIRECT_ASSIGN message ignored.");
 }
 ts::Errata
-Impl::handleRemovalQuery(IpHeader const&, ts::Buffer const& data) {
+Impl::handleRemovalQuery(IpHeader const&, ts::Buffer const& /* data ATS_UNUSED */)
{
   return log(LVL_INFO, "Unanticipated WCCP2_REMOVAL_QUERY message ignored.");
 }
 // ------------------------------------------------------
@@ -676,7 +676,7 @@ CacheImpl::housekeeping() {
 }
 
 ts::Errata
-CacheImpl::handleISeeYou(IpHeader const& ip_hdr, ts::Buffer const& chunk) {
+CacheImpl::handleISeeYou(IpHeader const& /* ip_hdr ATS_UNUSED */, ts::Buffer const&
chunk) {
   ts::Errata zret;
   ISeeYouMsg msg;
   // Set if our view of the group changes enough to bump the
@@ -834,7 +834,7 @@ CacheImpl::handleISeeYou(IpHeader const& ip_hdr, ts::Buffer const&
chunk) {
 }
 
 ts::Errata
-CacheImpl::handleRemovalQuery(IpHeader const& ip_hdr, ts::Buffer const& chunk) {
+CacheImpl::handleRemovalQuery(IpHeader const& /* ip_hdr ATS_UNUSED */, ts::Buffer const&
chunk) {
   ts::Errata zret;
   RemovalQueryMsg msg;
   time_t now = time(0);

http://git-wip-us.apache.org/repos/asf/trafficserver/blob/e32f83e5/lib/wccp/WccpMsg.cc
----------------------------------------------------------------------
diff --git a/lib/wccp/WccpMsg.cc b/lib/wccp/WccpMsg.cc
index 2d70b03..0ce41f6 100644
--- a/lib/wccp/WccpMsg.cc
+++ b/lib/wccp/WccpMsg.cc
@@ -1703,11 +1703,11 @@ void
 ISeeYouMsg::fill(
   detail::router::GroupData const& group,
   SecurityOption sec_opt,
-  detail::Assignment& assign,
+  detail::Assignment& /* assign ATS_UNUSED */,
   size_t to_caches,
   size_t n_routers,
   size_t n_caches,
-  bool send_capabilities
+  bool /* send_capabilities ATS_UNUSED */
 ) {
   m_header.fill(m_buffer, I_SEE_YOU);
   m_security.fill(m_buffer, sec_opt);

http://git-wip-us.apache.org/repos/asf/trafficserver/blob/e32f83e5/lib/wccp/WccpStatic.cc
----------------------------------------------------------------------
diff --git a/lib/wccp/WccpStatic.cc b/lib/wccp/WccpStatic.cc
index 6c32cca..bcb06a8 100644
--- a/lib/wccp/WccpStatic.cc
+++ b/lib/wccp/WccpStatic.cc
@@ -23,6 +23,7 @@
 # include "WccpLocal.h"
 # include "WccpMeta.h"
 # include "ink_error.h"
+# include "ink_defs.h"
 
 /* Solaris considers SIOCGIFCONF obsolete and only defines it if
  * BSD compatibility activated. */

http://git-wip-us.apache.org/repos/asf/trafficserver/blob/e32f83e5/mgmt/cli/CliCreateCommands.cc
----------------------------------------------------------------------
diff --git a/mgmt/cli/CliCreateCommands.cc b/mgmt/cli/CliCreateCommands.cc
index ff3c948..a63be68 100644
--- a/mgmt/cli/CliCreateCommands.cc
+++ b/mgmt/cli/CliCreateCommands.cc
@@ -304,7 +304,7 @@ xsystem(const char * cmd)
 }
 
 int
-Cmd_Help(ClientData clientData, Tcl_Interp * interp, int argc, const char *argv[])
+Cmd_Help(ClientData /* clientData ATS_UNUSED */, Tcl_Interp * /* interp ATS_UNUSED */, int
argc, const char *argv[])
 {
   Cli_Debug("looking for online help in %s\n", Layout::get()->datadir);
 

http://git-wip-us.apache.org/repos/asf/trafficserver/blob/e32f83e5/plugins/experimental/esi/lib/Variables.cc
----------------------------------------------------------------------
diff --git a/plugins/experimental/esi/lib/Variables.cc b/plugins/experimental/esi/lib/Variables.cc
index db76478..dfc6824 100644
--- a/plugins/experimental/esi/lib/Variables.cc
+++ b/plugins/experimental/esi/lib/Variables.cc
@@ -366,7 +366,7 @@ Variables::_parseCookieString(const char *str, int str_len) {
 }
 
 void
-Variables::_parseUserAgentString(const char *str, int str_len) {
+Variables::_parseUserAgentString(const char */* str ATS_UNUSED */, int /* str_len ATS_UNUSED
*/) {
   /*
   string user_agent_str(str, str_len); // need NULL-terminated version
   // TODO - code was here


Mime
View raw message