trafficserver-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From iga...@apache.org
Subject git commit: Backport TS-830 r1181096 / 2c67dc6b2ff530eadb802e7191a880f1657fa142 *) Management: traffic_line -r returns "Variable Not Found", even if it's a permission issue review: igalic, zwoop, zym Backport: igalic
Date Tue, 31 Jan 2012 23:56:12 GMT
Updated Branches:
  refs/heads/3.0.x 3778bdc48 -> f384a8a74


Backport TS-830 r1181096 / 2c67dc6b2ff530eadb802e7191a880f1657fa142
*) Management: traffic_line -r returns "Variable Not Found", even if
   it's a permission issue
review: igalic, zwoop, zym
Backport: igalic


Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/f384a8a7
Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/f384a8a7
Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/f384a8a7

Branch: refs/heads/3.0.x
Commit: f384a8a7431680e0eaa73bc9d6675d4b15a2790e
Parents: 3778bdc
Author: Leif Hedstrom <zwoop@apache.org>
Authored: Mon Oct 10 17:50:43 2011 +0000
Committer: Igor Galić <i.galic@brainsware.org>
Committed: Wed Feb 1 00:53:55 2012 +0100

----------------------------------------------------------------------
 CHANGES                               |    3 +++
 STATUS                                |    5 -----
 mgmt/api/remote/NetworkUtilsRemote.cc |    2 +-
 mgmt/cli/TrafficLine.cc               |    2 +-
 4 files changed, 5 insertions(+), 7 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/trafficserver/blob/f384a8a7/CHANGES
----------------------------------------------------------------------
diff --git a/CHANGES b/CHANGES
index 3ae9cb3..3a15ada 100644
--- a/CHANGES
+++ b/CHANGES
@@ -1,5 +1,8 @@
                                                          -*- coding: utf-8 -*-
 Changes with Apache Traffic Server 3.0.3
+  *) [TS-830] Better error when there are CLI permission problems, or
+   other problems preventing operation. Author: AdunGaos.
+
   *) [TS-1046] Add possibility to extend tsxs command line for -Iincludes.
 
   *) [TS-1047] fix lots of spelling mistakes

http://git-wip-us.apache.org/repos/asf/trafficserver/blob/f384a8a7/STATUS
----------------------------------------------------------------------
diff --git a/STATUS b/STATUS
index dab9c6f..591f0c5 100644
--- a/STATUS
+++ b/STATUS
@@ -40,11 +40,6 @@ A list of all bugs open for the next v3.0.2 release can be found at
 
 PATCHES ACCEPTED TO BACKPORT FROM TRUNK:
 
-  *) Management: traffic_line -r returns "Variable Not Found", even if it's a permission
issue
-   Trunk patch: http://svn.apache.org/viewvc?view=rev&rev=1181096
-   Jira: https://issues.apache.org/jira/browse/TS-830
-   +1: igalic, zwoop, zym
-
   *) HttpSM: slow log can not print logs well on 32-bit system.
    Trunk patch: http://svn.apache.org/viewvc?view=rev&rev=1225944
    Jira: https://issues.apache.org/jira/browse/TS-1014

http://git-wip-us.apache.org/repos/asf/trafficserver/blob/f384a8a7/mgmt/api/remote/NetworkUtilsRemote.cc
----------------------------------------------------------------------
diff --git a/mgmt/api/remote/NetworkUtilsRemote.cc b/mgmt/api/remote/NetworkUtilsRemote.cc
index cedb965..47d4e3b 100644
--- a/mgmt/api/remote/NetworkUtilsRemote.cc
+++ b/mgmt/api/remote/NetworkUtilsRemote.cc
@@ -168,7 +168,7 @@ ts_connect()
 #endif
   // connect call
   if (connect(main_socket_fd, (struct sockaddr *) &client_sock, sockaddr_len) < 0)
{
-    //fprintf(stderr, "[connect] ERROR (main_socket_fd %d): %s\n", main_socket_fd, strerror(int(errno)));
+    fprintf(stderr, "[connect] ERROR (main_socket_fd %d): %s\n", main_socket_fd, strerror(int(errno)));
     close(main_socket_fd);
     main_socket_fd = -1;
     goto ERROR;                 //connection is down

http://git-wip-us.apache.org/repos/asf/trafficserver/blob/f384a8a7/mgmt/cli/TrafficLine.cc
----------------------------------------------------------------------
diff --git a/mgmt/cli/TrafficLine.cc b/mgmt/cli/TrafficLine.cc
index 4ebec29..c57e759 100644
--- a/mgmt/cli/TrafficLine.cc
+++ b/mgmt/cli/TrafficLine.cc
@@ -80,7 +80,7 @@ handleArgInvocation()
       TSRecordEle *rec_ele = TSRecordEleCreate();
 
       if ((err = TSRecordGet(ReadVar, rec_ele)) != TS_ERR_OKAY) {
-        fprintf(stderr, "%s: Variable Not Found\n", programName);
+        fprintf(stderr, "%s: %s\n", programName, TSGetErrorMessage(err));
       } else {
         switch (rec_ele->rec_type) {
         case TS_REC_INT:


Mime
View raw message