From users-return-4873-apmail-openejb-users-archive=openejb.apache.org@openejb.apache.org Fri Mar 2 10:40:05 2012 Return-Path: X-Original-To: apmail-openejb-users-archive@www.apache.org Delivered-To: apmail-openejb-users-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 50A78984F for ; Fri, 2 Mar 2012 10:40:05 +0000 (UTC) Received: (qmail 63617 invoked by uid 500); 2 Mar 2012 10:40:05 -0000 Delivered-To: apmail-openejb-users-archive@openejb.apache.org Received: (qmail 63594 invoked by uid 500); 2 Mar 2012 10:40:05 -0000 Mailing-List: contact users-help@openejb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: users@openejb.apache.org Delivered-To: mailing list users@openejb.apache.org Received: (qmail 63585 invoked by uid 99); 2 Mar 2012 10:40:05 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Mar 2012 10:40:05 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of rmannibucau@gmail.com designates 209.85.216.169 as permitted sender) Received: from [209.85.216.169] (HELO mail-qy0-f169.google.com) (209.85.216.169) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Mar 2012 10:39:58 +0000 Received: by qcsd16 with SMTP id d16so320446qcs.28 for ; Fri, 02 Mar 2012 02:39:38 -0800 (PST) Received-SPF: pass (google.com: domain of rmannibucau@gmail.com designates 10.224.111.16 as permitted sender) client-ip=10.224.111.16; Authentication-Results: mr.google.com; spf=pass (google.com: domain of rmannibucau@gmail.com designates 10.224.111.16 as permitted sender) smtp.mail=rmannibucau@gmail.com; dkim=pass header.i=rmannibucau@gmail.com Received: from mr.google.com ([10.224.111.16]) by 10.224.111.16 with SMTP id q16mr6624529qap.56.1330684778233 (num_hops = 1); Fri, 02 Mar 2012 02:39:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type; bh=h+SX2vEVMQiIhWkxEl54XUY4lKCVsuNbdBpIqvr6tm0=; b=e5j51BZ72MX3b4abUpGZIDUaaTgDmZOppOZwtQ3WMckifK1js0vshdF8aA6rJPvAuN i/kpKSwRXAGR/pJMbHFwjg/cGi3SxdOMjNSrSeV6dq8HPGMd7mTMNwJG5tdywHUUIRdO HX7WSo5ZTiaeAneLrnnLJFcA69B3cEDf8vr6PgbwnCeu9dheWiXsj5ghistMk/MqqxMN TzB6cah2vIvwiG9h/3sXOnmvWe3eBphquZ37+XYOfwdfyEewZZELwokvW9eWWvu6mvyh BZKj+GUK8vZtSxM8Zg9J2Znj8txQSTlSPmvGNzCXL5ti5de3vyJoXg8dtLrBfVNRklkL yHHA== Received: by 10.224.111.16 with SMTP id q16mr5577090qap.56.1330684778154; Fri, 02 Mar 2012 02:39:38 -0800 (PST) MIME-Version: 1.0 Received: by 10.229.138.131 with HTTP; Fri, 2 Mar 2012 02:39:18 -0800 (PST) In-Reply-To: References: From: Romain Manni-Bucau Date: Fri, 2 Mar 2012 11:39:18 +0100 Message-ID: Subject: Re: openejb ignores web.xml when deploying archived app To: users@openejb.apache.org Content-Type: multipart/alternative; boundary=20cf3074d9e082891e04ba4031c0 X-Virus-Checked: Checked by ClamAV on apache.org --20cf3074d9e082891e04ba4031c0 Content-Type: text/plain; charset=ISO-8859-1 our deployment is clearly based on unpack directory, however to discrover module type we don't unpack before (to avoid to unpack jar for instance). so we maybe have an issue here. I'll try to push a fix in the day within the following hour on the trunk. - Romain 2012/3/2 Borislav Kapukaranov > Hello folks, > > Since last I wrote you I had success in making openEjb run on Equinox and > got some examples up and running. > While testing I noticed that openEjb works fine when I deploy unarchived > web apps, but fails to identify the WebModule when the app is archived. > This is due to this piece of code in * > org.apache.openejb.config.DeploymentLoader* (line 1419): > > if (!entry.isDirectory() && entryName.startsWith("WEB-INF/") && > entryName.indexOf('/', "WEB-INF/".length()) > 0) { > descriptors.put(entryName, new URL(jarURL, entry.getName())); > } > > Here *entryName="WEB-INF/web.xml"* and *entryName.indexOf('/', "WEB-INF/" > .length())* returns -1, effectively ignoring the web.xml and not including > it in the descriptors collection. > Is this intentionally done? I'm new to openEjb so I could be missing > something fundamental. > > I'm using beta-2. > > In the unarchived case it works fine because the code just takes the > WEB-INF directory and adds all files under it that are not directories in > the collection. > > Thanks, > Borislav > --20cf3074d9e082891e04ba4031c0--