tomee-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TOMEE-2438) Centralise TomEE and OpenEJB system properties
Date Wed, 02 Jan 2019 10:49:00 GMT

    [ https://issues.apache.org/jira/browse/TOMEE-2438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16731934#comment-16731934
] 

ASF GitHub Bot commented on TOMEE-2438:
---------------------------------------

GitHub user gerdogdu opened a pull request:

    https://github.com/apache/tomee/pull/343

    (TOMEE-2438) Centralise TomEE and OpenEJB system properties

    Initial attempt for TomEE system config. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gerdogdu/tomee TOMEE-2435-branch

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tomee/pull/343.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #343
    
----
commit 02ed7ee2fb84164399018ee82dceb08e5e9ed24f
Author: Gurkan Erdogdu <cgerdogdu@...>
Date:   2019-01-02T10:46:03Z

    (TOMEE-2438) Centralise TomEE and OpenEJB system properties

----


> Centralise TomEE and OpenEJB system properties
> ----------------------------------------------
>
>                 Key: TOMEE-2438
>                 URL: https://issues.apache.org/jira/browse/TOMEE-2438
>             Project: TomEE
>          Issue Type: Improvement
>          Components: TomEE Build
>            Reporter: Gurkan Erdogdu
>            Priority: Minor
>              Labels: pull-request-available
>
> There are lots of known and unknown system properties in the current code
> base. We will introduce TomEESystemProperties and
> OpenEJBSystemProperties classes to hold these system property constants
> and provide clear comment what it does.
> For example:
> {code:java}
> class TomEESystemProperties{
>        public static final String TOMEE_FORCE_RELOADABLE =
> "tomee.force-reloadable";
> ....
> }
> class OpenEJBSystemProperties{
>       public static final String OPENEJB_CROSSCONTEXT_PROPERTY =
> "openejb.crosscontext";
> ....
> }{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message