From commits-return-45582-archive-asf-public=cust-asf.ponee.io@tomee.apache.org Fri Dec 21 11:33:47 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 3C24D180627 for ; Fri, 21 Dec 2018 11:33:47 +0100 (CET) Received: (qmail 41997 invoked by uid 500); 21 Dec 2018 10:33:46 -0000 Mailing-List: contact commits-help@tomee.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tomee.apache.org Delivered-To: mailing list commits@tomee.apache.org Received: (qmail 41988 invoked by uid 500); 21 Dec 2018 10:33:46 -0000 Delivered-To: apmail-openejb-commits@openejb.apache.org Received: (qmail 41985 invoked by uid 99); 21 Dec 2018 10:33:46 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 21 Dec 2018 10:33:46 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id F1E4A180DA4 for ; Fri, 21 Dec 2018 10:33:45 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id g2iyeuRawoj7 for ; Fri, 21 Dec 2018 10:33:44 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id E819760DDC for ; Fri, 21 Dec 2018 10:27:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 83809E1013 for ; Fri, 21 Dec 2018 10:27:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2139D24008 for ; Fri, 21 Dec 2018 10:27:00 +0000 (UTC) Date: Fri, 21 Dec 2018 10:27:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: commits@openejb.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (TOMEE-2261) Make service.bat compatible with JDK11+ MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/TOMEE-2261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16726629#comment-16726629 ] ASF GitHub Bot commented on TOMEE-2261: --------------------------------------- Github user jgallimore commented on the issue: https://github.com/apache/tomee/pull/301 Thanks for this. I'll give it a quick test and we'll merge it in. > Make service.bat compatible with JDK11+ > --------------------------------------- > > Key: TOMEE-2261 > URL: https://issues.apache.org/jira/browse/TOMEE-2261 > Project: TomEE > Issue Type: Improvement > Components: TomEE Core Server > Affects Versions: 7.0.5, 7.1.0, 8.0.0-M1 > Reporter: Bruno Baptista > Assignee: Jonathan Gallimore > Priority: Major > Labels: pull-request-available > > service.bat fails to start TomEE as a service on Windows 2012 R2, at least, while using OpenJDK 11. > Upon further analysis, The issue was found to be the absence of a jdk\jre folder inside OpenJDK 11 and the use of the endorsed property. > We need to upgrade the file to make it compatible with newer JDK versions. > The batch file has to be, either improved by considering the different Java versions, or duplicated by keeping the current one and adding a new one for JDK 11+. -- This message was sent by Atlassian JIRA (v7.6.3#76005)