tomee-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TOMEE-2337) Code cleanup: module openejb-loader
Date Sat, 08 Dec 2018 22:51:00 GMT

    [ https://issues.apache.org/jira/browse/TOMEE-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16713797#comment-16713797
] 

ASF GitHub Bot commented on TOMEE-2337:
---------------------------------------

Github user cicekhayri commented on a diff in the pull request:

    https://github.com/apache/tomee/pull/262#discussion_r240018831
  
    --- Diff: container/openejb-loader/src/main/java/org/apache/openejb/loader/FileUtils.java
---
    @@ -20,18 +20,25 @@
     import java.io.FileNotFoundException;
     import java.io.IOException;
     import java.util.Hashtable;
    +import java.util.concurrent.ThreadLocalRandom;
     
     @SuppressWarnings("PMD.OverrideBothEqualsAndHashcode")
     public class FileUtils {
     
    -    private static final java.util.Random _random = new java.util.Random();
    +    private static final ThreadLocalRandom _random = ThreadLocalRandom.current();
    --- End diff --
    
    Okej, is it best to revert it back for now 


> Code cleanup: module openejb-loader
> -----------------------------------
>
>                 Key: TOMEE-2337
>                 URL: https://issues.apache.org/jira/browse/TOMEE-2337
>             Project: TomEE
>          Issue Type: Improvement
>    Affects Versions: 8.0.0-M1, 7.1.0
>            Reporter: Hayri Cicek
>            Priority: Trivial
>              Labels: pull-request-available
>
> Use diamond operator, JavaDoc and if possible final variables/parameters



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message