tomee-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TOMEE-2314) Code Cleanup: openejb-multicast, openejb-axis, openejb-common-cli, openejb-ejbd, openejb-server, openejb-webservices, tomee-common
Date Wed, 05 Dec 2018 15:16:00 GMT

    [ https://issues.apache.org/jira/browse/TOMEE-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16710210#comment-16710210
] 

ASF GitHub Bot commented on TOMEE-2314:
---------------------------------------

Github user rzo1 commented on a diff in the pull request:

    https://github.com/apache/tomee/pull/231#discussion_r239105917
  
    --- Diff: tomee/tomee-common/src/main/java/org/apache/tomee/installer/Installer.java ---
    @@ -32,31 +32,31 @@
         private Status status = Status.NONE;
         private boolean force;
     
    -    private static final boolean listenerInstalled;
    -    private static final boolean agentInstalled;
    +    private static final boolean LISTENERINSTALLED;
    +    private static final boolean AGENTINSTALLED;
    --- End diff --
    
    `AGENT_INSTALLED`


> Code Cleanup: openejb-multicast,  openejb-axis,  openejb-common-cli,  openejb-ejbd, 
openejb-server,  openejb-webservices,  tomee-common
> ----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: TOMEE-2314
>                 URL: https://issues.apache.org/jira/browse/TOMEE-2314
>             Project: TomEE
>          Issue Type: Improvement
>    Affects Versions: 7.1.0
>            Reporter: Hayri Cicek
>            Priority: Trivial
>              Labels: pull-request-available
>
> This was little to big but next time will make the JIRA issue for each module  before
start coding 
> Modules worked in :
> openejb-multicast,
> openejb-axis,
> openejb-common-cli,
> openejb-ejbd,
> openejb-server,
> openejb-webservices,
> tomee-common,
>  
> Usage of dimond operator, remove unused import and Java Doc



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message