tomee-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Cesar Hernandez (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TOMEE-2284) MicroProfile Metrics Example for @Metered
Date Thu, 20 Dec 2018 03:02:00 GMT

    [ https://issues.apache.org/jira/browse/TOMEE-2284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16725541#comment-16725541
] 

Cesar Hernandez commented on TOMEE-2284:
----------------------------------------

[@ferdisn|https://github.com/ferdisn]  [~ivanjunckes]

I see already on master a metered example but is lacking of readme file.

I this still a WIP or do you prefer to create a new ticket to cover the creation of the README.adoc
file?

> MicroProfile Metrics Example for @Metered
> -----------------------------------------
>
>                 Key: TOMEE-2284
>                 URL: https://issues.apache.org/jira/browse/TOMEE-2284
>             Project: TomEE
>          Issue Type: Sub-task
>          Components: Examples and Documentation
>            Reporter: Ivan Junckes Filho
>            Assignee: Ivan Junckes Filho
>            Priority: Minor
>              Labels: examples
>         Attachments: image-2018-11-23-11-06-41-322.png, image-2018-11-23-11-07-37-555.png
>
>
> We would like to have an example for MicroProfile Metrics @Metered annotation.
> Here is a quick tutorial on MicroProfile Metrics if you are not aware:
> [https://www.tomitribe.com/blog/getting-started-with-microprofile-metrics/]
> Fork / clone the TomEE project from here:
> [https://github.com/apache/tomee]
> Example name should be _mp-metrics-metered_, following the standard already in the project.
> All the examples are in:
> [https://github.com/apache/tomee/tree/master/examples]
> See this example of @Counted for reference:
> [https://github.com/apache/tomee/tree/master/examples/mp-metrics-counted]
> See these two PRs for the diff for @Counted, it will help you see how simple it is:
> [https://github.com/apache/tomee/pull/203]
> [https://github.com/apache/tomee/pull/207]
> What you have to do is:
> 1 - Create a method in the WeatherService class with @Metered
> 2 - Have a WeatherServiceTest for the GET and OPTIONS scenarios of @Metered
> 3 - Make sure you have tests for Prometheus and JSON formats
> 4 - Make sure all the tests pass
> After that submit a PR and we'll review it.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message