tomee-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TOMEE-2261) Make service.bat compatible with JDK11+
Date Fri, 21 Dec 2018 10:21:00 GMT

    [ https://issues.apache.org/jira/browse/TOMEE-2261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16726622#comment-16726622
] 

ASF GitHub Bot commented on TOMEE-2261:
---------------------------------------

GitHub user gerwinjansen opened a pull request:

    https://github.com/apache/tomee/pull/301

    Fixes TOMEE-2261 Make service.bat compatible with JDK11+

    When JAVA_HOME is set to a path with a space (e.g. C:\Program Files\Java\jdk11.0.1), I
get this error:
    ```
    C:\Program Files\TomEE\bin>service install
    11 was unexpected at this time.
    ```
    I fixed it by adding quotes to the path.
    
    Bonus: removal of superfluous tokens which are not used.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gerwinjansen/tomee TOMEE-2261

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tomee/pull/301.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #301
    
----
commit e420c0fe6b309d2238dc9c330cc092a32766dc5f
Author: Gerwin Jansen <gerwin84@...>
Date:   2018-12-21T10:03:55Z

    Fixes TOMEE-2261 Make service.bat compatible with JDK11+

----


> Make service.bat compatible with JDK11+
> ---------------------------------------
>
>                 Key: TOMEE-2261
>                 URL: https://issues.apache.org/jira/browse/TOMEE-2261
>             Project: TomEE
>          Issue Type: Improvement
>          Components: TomEE Core Server
>    Affects Versions: 7.0.5, 7.1.0, 8.0.0-M1
>            Reporter: Bruno Baptista
>            Assignee: Jonathan Gallimore
>            Priority: Major
>              Labels: pull-request-available
>
> service.bat fails to start TomEE as a service on Windows 2012 R2, at least, while using
OpenJDK 11.
> Upon further analysis, The issue was found to be the absence of a jdk\jre folder inside
OpenJDK 11 and the use of the endorsed property.
> We need to upgrade the file to make it compatible with newer JDK versions.
> The batch file has to be, either improved by considering the different Java versions,
or duplicated by keeping the current one and adding a new one for JDK 11+.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message