tomee-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jgallim...@apache.org
Subject [1/6] tomee git commit: removes String concatenation loop in Assembler
Date Mon, 26 Nov 2018 14:50:40 GMT
Repository: tomee
Updated Branches:
  refs/heads/master 4a6183a11 -> e893b19b6


removes String concatenation loop in Assembler


Project: http://git-wip-us.apache.org/repos/asf/tomee/repo
Commit: http://git-wip-us.apache.org/repos/asf/tomee/commit/442a81b3
Tree: http://git-wip-us.apache.org/repos/asf/tomee/tree/442a81b3
Diff: http://git-wip-us.apache.org/repos/asf/tomee/diff/442a81b3

Branch: refs/heads/master
Commit: 442a81b3e78b7700f0420573927872bedbec30a4
Parents: f032a7f
Author: Otavio Santana <otaviopolianasantana@gmail.com>
Authored: Thu Nov 22 13:23:49 2018 -0200
Committer: Otavio Santana <otaviopolianasantana@gmail.com>
Committed: Thu Nov 22 13:23:49 2018 -0200

----------------------------------------------------------------------
 .../java/org/apache/openejb/assembler/classic/Assembler.java  | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/tomee/blob/442a81b3/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java
----------------------------------------------------------------------
diff --git a/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java
b/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java
index 72659d9..e0a5fcb 100644
--- a/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java
+++ b/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java
@@ -786,12 +786,13 @@ public class Assembler extends AssemblerTool implements org.apache.openejb.spi.A
             final List<String> used = getDuplicates(appInfo);
 
             if (used.size() > 0) {
-                String message = logger.error("createApplication.appFailedDuplicateIds",
appInfo.path);
+                StringBuilder message = new StringBuilder(logger.error("createApplication.appFailedDuplicateIds"
+                        , appInfo.path));
                 for (final String id : used) {
                     logger.error("createApplication.deploymentIdInUse", id);
-                    message += "\n    " + id;
+                    message.append("\n    ").append(id);
                 }
-                throw new DuplicateDeploymentIdException(message);
+                throw new DuplicateDeploymentIdException(message.toString());
             }
 
             final ClassLoader oldCl = Thread.currentThread().getContextClassLoader();


Mime
View raw message