tomee-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TOMEE-2290) Metrics Microprofile Example for @Timed
Date Mon, 26 Nov 2018 17:06:00 GMT

    [ https://issues.apache.org/jira/browse/TOMEE-2290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16699300#comment-16699300
] 

ASF GitHub Bot commented on TOMEE-2290:
---------------------------------------

Github user rmannibucau commented on a diff in the pull request:

    https://github.com/apache/tomee/pull/218#discussion_r236342580
  
    --- Diff: examples/mp-metrics-timed/src/test/java/WeatherServiceTest.java ---
    @@ -157,7 +159,10 @@ private void assertJsonFormat(final String metricPath) {
             };
     
             Stream.of(expected)
    -                .forEach(text -> assertTrue("Expected: " + text + " to be present
in " + metric, metric.contains(text)));
    +                .forEach(text ->
    +                        assertTrue(
    +                                "Expected: " + text + " to be present in " + metric,
    +                                expectedJson.getJsonObject("weather_day_status").get("count")
!= null));
    --- End diff --
    
    s/count/text/ ;)


> Metrics Microprofile Example for @Timed
> ---------------------------------------
>
>                 Key: TOMEE-2290
>                 URL: https://issues.apache.org/jira/browse/TOMEE-2290
>             Project: TomEE
>          Issue Type: Sub-task
>            Reporter: Ivan Junckes Filho
>            Assignee: Ivan Junckes Filho
>            Priority: Major
>              Labels: pull-request-available
>
> We would like to have an example for MicroProfile Metrics @Timed annotation.
> Here is a quick tutorial on MicroProfile Metrics if you are not aware:
> [https://www.tomitribe.com/blog/getting-started-with-microprofile-metrics/]
> Fork / clone the TomEE project from here:
> [https://github.com/apache/tomee]
> Example name should be _mp-metrics-timed_, following the standard already in the project.
> All the examples are in:
> [https://github.com/apache/tomee/tree/master/examples]
> See this example of @Counted for reference:
> [https://github.com/apache/tomee/tree/master/examples/mp-metrics-counted]
> See these two PRs for the diff for @Counted, it will help you see how simple it is:
> [https://github.com/apache/tomee/pull/203]
> [https://github.com/apache/tomee/pull/207]
> What you have to do is:
> 1 - Create a JAX-RS resource WeatherService that has one method with @Timed
> 2 - Have a WeatherServiceTest for the GET and OPTIONS scenarios of @Timed
> 3 - Make sure you have tests for Prometheus and JSON formats
> 4 - Make sure all the tests pass
> After that submit a PR and we'll review it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message