From commits-return-43572-archive-asf-public=cust-asf.ponee.io@tomee.apache.org Tue Oct 23 13:21:03 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 65CBD180675 for ; Tue, 23 Oct 2018 13:21:03 +0200 (CEST) Received: (qmail 25494 invoked by uid 500); 23 Oct 2018 11:21:02 -0000 Mailing-List: contact commits-help@tomee.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tomee.apache.org Delivered-To: mailing list commits@tomee.apache.org Received: (qmail 25483 invoked by uid 500); 23 Oct 2018 11:21:02 -0000 Delivered-To: apmail-openejb-commits@openejb.apache.org Received: (qmail 25480 invoked by uid 99); 23 Oct 2018 11:21:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 23 Oct 2018 11:21:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 0187AC041A for ; Tue, 23 Oct 2018 11:21:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id G7TrHPxEvB1l for ; Tue, 23 Oct 2018 11:21:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 081285F230 for ; Tue, 23 Oct 2018 11:21:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id A09BFE0E3E for ; Tue, 23 Oct 2018 11:21:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 69FBE252B4 for ; Tue, 23 Oct 2018 11:21:00 +0000 (UTC) Date: Tue, 23 Oct 2018 11:21:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: commits@openejb.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (TOMEE-2261) Make service.bat compatible with JDK11+ MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/TOMEE-2261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16660453#comment-16660453 ] ASF GitHub Bot commented on TOMEE-2261: --------------------------------------- GitHub user brunobat opened a pull request: https://github.com/apache/tomee/pull/178 TOMEE-2261 - Make service.bat compatible with JDK11+ Detect java version and act on it. After java 11: - Remove jre references because they are invalid when using the JDK. - Remove endorced property def. because is no longer supported. This has been developped with Tomee 7.0.6-SNAPSHOT and tested with: - Windows 2012 R2 - OpenJDK11-jdk_x64_windows_openj9_11.0.1_13 - OpenJDK8U-jdk_x64_windows_hotspot_8u181b13 Signed-off-by: brunobat You can merge this pull request into a Git repository by running: $ git pull https://github.com/brunobat/tomee fix-win-service-j11 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tomee/pull/178.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #178 ---- commit 4309ec73f2c452fed5ca96dee6d344247dbee27b Author: brunobat Date: 2018-10-23T11:14:22Z Detect java version and act on it. After java 11: - Remove jre references because they are invalid when using the JDK. - Remove endorced property def. because is no longer supported. Signed-off-by: brunobat ---- > Make service.bat compatible with JDK11+ > --------------------------------------- > > Key: TOMEE-2261 > URL: https://issues.apache.org/jira/browse/TOMEE-2261 > Project: TomEE > Issue Type: Improvement > Components: TomEE Core Server > Affects Versions: 8.0.0-Final, 7.0.5, 7.0.6, 7.1.1, 7.1.0 > Reporter: Bruno Baptista > Priority: Major > Labels: pull-request-available > > service.bat fails to start TomEE as a service on Windows 2012 R2, at least, while using OpenJDK 11. > Upon further analysis, The issue was found to be the absence of a jdk\jre folder inside OpenJDK 11 and the use of the endorsed property. > We need to upgrade the file to make it compatible with newer JDK versions. > The batch file has to be, either improved by considering the different Java versions, or duplicated by keeping the current one and adding a new one for JDK 11+. -- This message was sent by Atlassian JIRA (v7.6.3#76005)