tomee-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TOMEE-2261) Make service.bat compatible with JDK11+
Date Tue, 23 Oct 2018 11:21:00 GMT

    [ https://issues.apache.org/jira/browse/TOMEE-2261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16660453#comment-16660453
] 

ASF GitHub Bot commented on TOMEE-2261:
---------------------------------------

GitHub user brunobat opened a pull request:

    https://github.com/apache/tomee/pull/178

    TOMEE-2261 - Make service.bat compatible with JDK11+

    Detect java version and act on it. After java 11: 
    - Remove jre references because they are invalid when using the JDK. 
    - Remove endorced property def. because is no longer supported.
    
    This has been developped with Tomee 7.0.6-SNAPSHOT and tested with:
    - Windows 2012 R2
    - OpenJDK11-jdk_x64_windows_openj9_11.0.1_13
    - OpenJDK8U-jdk_x64_windows_hotspot_8u181b13
    
    Signed-off-by: brunobat <brunobat@gmail.com>

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/brunobat/tomee fix-win-service-j11

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tomee/pull/178.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #178
    
----
commit 4309ec73f2c452fed5ca96dee6d344247dbee27b
Author: brunobat <brunobat@...>
Date:   2018-10-23T11:14:22Z

    Detect java version and act on it. After java 11: - Remove jre references because they
are invalid when using the JDK. - Remove endorced property def. because is no longer supported.
    
    Signed-off-by: brunobat <brunobat@gmail.com>

----


> Make service.bat compatible with JDK11+
> ---------------------------------------
>
>                 Key: TOMEE-2261
>                 URL: https://issues.apache.org/jira/browse/TOMEE-2261
>             Project: TomEE
>          Issue Type: Improvement
>          Components: TomEE Core Server
>    Affects Versions: 8.0.0-Final, 7.0.5, 7.0.6, 7.1.1, 7.1.0
>            Reporter: Bruno Baptista
>            Priority: Major
>              Labels: pull-request-available
>
> service.bat fails to start TomEE as a service on Windows 2012 R2, at least, while using
OpenJDK 11.
> Upon further analysis, The issue was found to be the absence of a jdk\jre folder inside
OpenJDK 11 and the use of the endorsed property.
> We need to upgrade the file to make it compatible with newer JDK versions.
> The batch file has to be, either improved by considering the different Java versions,
or duplicated by keeping the current one and adding a new one for JDK 11+.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message