tomee-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jgallim...@apache.org
Subject [01/12] tomee git commit: Adding some TODOs
Date Fri, 14 Sep 2018 15:22:31 GMT
Repository: tomee
Updated Branches:
  refs/heads/master 6ba7fc5f7 -> 250bdbec1


Adding some TODOs


Project: http://git-wip-us.apache.org/repos/asf/tomee/repo
Commit: http://git-wip-us.apache.org/repos/asf/tomee/commit/e2879a9c
Tree: http://git-wip-us.apache.org/repos/asf/tomee/tree/e2879a9c
Diff: http://git-wip-us.apache.org/repos/asf/tomee/diff/e2879a9c

Branch: refs/heads/master
Commit: e2879a9c0f460d9e385011074bff4c271f1c1ad3
Parents: 92fb90f
Author: Jonathan Gallimore <jon@jrg.me.uk>
Authored: Thu Aug 30 15:51:45 2018 +0100
Committer: Jonathan Gallimore <jon@jrg.me.uk>
Committed: Thu Aug 30 15:51:45 2018 +0100

----------------------------------------------------------------------
 .../java/org/apache/openejb/assembler/classic/Assembler.java   | 6 ++++++
 1 file changed, 6 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/tomee/blob/e2879a9c/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java
----------------------------------------------------------------------
diff --git a/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java
b/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java
index b013752..7e5094b 100644
--- a/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java
+++ b/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java
@@ -2835,6 +2835,9 @@ public class Assembler extends AssemblerTool implements org.apache.openejb.spi.A
         if (Container.class.isInstance(service) && LocalMBeanServer.isJMXActive())
{
             final ObjectName objectName = ObjectNameBuilder.uniqueName("containers", serviceInfo.id,
service);
             try {
+
+                // TODO: is there anything further we want to include here?
+                // TODO: live state for MDB pool
                 LocalMBeanServer.get().registerMBean(new DynamicMBeanWrapper(new JMXContainer(serviceInfo,
(Container) service)), objectName);
                 containerObjectNames.add(objectName);
             } catch (final Exception | NoClassDefFoundError e) {
@@ -3248,6 +3251,9 @@ public class Assembler extends AssemblerTool implements org.apache.openejb.spi.A
 
             // create the connection manager
             final ConnectionManager connectionManager = (ConnectionManager) connectionManagerRecipe.create();
+            // TODO: wrap GenericConnectionManager with something to provide stats via JMX
+
+
             if (connectionManager == null) {
                 throw new OpenEJBRuntimeException(messages.format("assembler.invalidConnectionManager",
serviceInfo.id));
             }


Mime
View raw message