From commits-return-41663-archive-asf-public=cust-asf.ponee.io@tomee.apache.org Wed Jan 10 11:51:05 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id E9AA118062E for ; Wed, 10 Jan 2018 11:51:05 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id D9331160C23; Wed, 10 Jan 2018 10:51:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 2A799160C2E for ; Wed, 10 Jan 2018 11:51:05 +0100 (CET) Received: (qmail 3084 invoked by uid 500); 10 Jan 2018 10:51:04 -0000 Mailing-List: contact commits-help@tomee.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tomee.apache.org Delivered-To: mailing list commits@tomee.apache.org Received: (qmail 3075 invoked by uid 500); 10 Jan 2018 10:51:04 -0000 Delivered-To: apmail-openejb-commits@openejb.apache.org Received: (qmail 3072 invoked by uid 99); 10 Jan 2018 10:51:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Jan 2018 10:51:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id B3BA41A08CA for ; Wed, 10 Jan 2018 10:51:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.911 X-Spam-Level: X-Spam-Status: No, score=-99.911 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id f1Fue53NVMOp for ; Wed, 10 Jan 2018 10:51:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 9BFDC5F620 for ; Wed, 10 Jan 2018 10:51:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 39A07E0594 for ; Wed, 10 Jan 2018 10:51:02 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 3EB8D274D1 for ; Wed, 10 Jan 2018 10:51:00 +0000 (UTC) Date: Wed, 10 Jan 2018 10:51:00 +0000 (UTC) From: "Jonathan Gallimore (JIRA)" To: commits@openejb.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Assigned] (TOMEE-2161) TomEE-embedded: Attribute "keystoreFile" is not set correctly in Container startup MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/TOMEE-2161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Gallimore reassigned TOMEE-2161: ----------------------------------------- Assignee: Jonathan Gallimore > TomEE-embedded: Attribute "keystoreFile" is not set correctly in Container startup > ---------------------------------------------------------------------------------- > > Key: TOMEE-2161 > URL: https://issues.apache.org/jira/browse/TOMEE-2161 > Project: TomEE > Issue Type: Bug > Affects Versions: 7.0.5 > Reporter: Lars Fessen > Assignee: Jonathan Gallimore > > When using the Tomee-embedded Container and trying to use HTTPs the "keystoreFile"-attribute is not set correctly. (We are using tomee-embedded 7.0.0 but the github master has still the same bug) > *How I use the container:* > {code:java} > Configuration cfg = new Configuration(); > cfg.setSsl(true); > cfg.setKeystoreFile("my/path/to/keystore/keystore.p12"); > cfg.setKeystoreType("PKCS12"); > cfg.setKeystorePass("changeit"); > cfg.setSslProtocol("TLS"); > cfg.setKeyAlias("alias"); > cfg.setSkipHttp(true); > cfg.setHttpsPort(config.getPort()); > org.apache.tomee.embedded.Container container; > container = new Container(); > container.setup(cfg); > container.start(); > {code} > *Where is the bug in Tomee-embedded:* > https://github.com/apache/tomee/blob/master/tomee/tomee-embedded/src/main/java/org/apache/tomee/embedded/Container.java > Line: 632 > {code:java} > if (configuration.getKeystoreFile() != null) { > httpsConnector.setAttribute("", configuration.getKeystoreFile()); > } > {code} > *What is the solution (in my opinion):* > {code:java} > if (configuration.getKeystoreFile() != null) { > httpsConnector.setAttribute("keystoreFile", configuration.getKeystoreFile()); > } > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029)