Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id CE789200D50 for ; Mon, 4 Dec 2017 10:12:06 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id CCF3D160C1B; Mon, 4 Dec 2017 09:12:06 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 1CEA8160BF9 for ; Mon, 4 Dec 2017 10:12:05 +0100 (CET) Received: (qmail 4693 invoked by uid 500); 4 Dec 2017 09:12:05 -0000 Mailing-List: contact commits-help@tomee.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tomee.apache.org Delivered-To: mailing list commits@tomee.apache.org Received: (qmail 4684 invoked by uid 500); 4 Dec 2017 09:12:05 -0000 Delivered-To: apmail-openejb-commits@openejb.apache.org Received: (qmail 4681 invoked by uid 99); 4 Dec 2017 09:12:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 Dec 2017 09:12:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 6CF861A0736 for ; Mon, 4 Dec 2017 09:12:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -98.702 X-Spam-Level: X-Spam-Status: No, score=-98.702 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_NUMSUBJECT=0.5, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id Lj9-nTgX2Fp5 for ; Mon, 4 Dec 2017 09:12:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 8A0D160E3F for ; Mon, 4 Dec 2017 09:12:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 71D74E0EEF for ; Mon, 4 Dec 2017 09:12:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2FB76255C5 for ; Mon, 4 Dec 2017 09:12:00 +0000 (UTC) Date: Mon, 4 Dec 2017 09:12:00 +0000 (UTC) From: "Romain Manni-Bucau (JIRA)" To: commits@openejb.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (TOMEE-2152) ApplicationComposers @Default fails to detect main classes for Gradle >= 4 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 04 Dec 2017 09:12:07 -0000 [ https://issues.apache.org/jira/browse/TOMEE-2152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Romain Manni-Bucau updated TOMEE-2152: -------------------------------------- Summary: ApplicationComposers @Default fails to detect main classes for Gradle >= 4 (was: ApplicationComposers fails to detect main classes for Gradle >= 4) > ApplicationComposers @Default fails to detect main classes for Gradle >= 4 > -------------------------------------------------------------------------- > > Key: TOMEE-2152 > URL: https://issues.apache.org/jira/browse/TOMEE-2152 > Project: TomEE > Issue Type: Bug > Affects Versions: 7.0.4 > Reporter: Jens Berke > Attachments: ApplicationComposers.patch > > > Starting with Gradle 4, the output directory layout has been changed, and as a result the detection of the main classes directory in org.apache.openejb.testing.ApplicationComposers.addWebApp fails. > The changes are documented in the [release notes for Gradle 4|https://docs.gradle.org/4.0/release-notes.html], see chapters "Multiple class directories for a single source set" and "Location of classes in the build directory" there. > As a workaround it is currently possible to change the output directory structure in the Gradle build script to what ApplicationComposers.addWebApp expects, but this possibility is scheduled to be removed in Gradle 5.0. > The attached patch only demonstrates the minimal change necessary for Gradle >= 4, but it also breaks backwards compatibility with Gradle <= 3. Therefore it might be a good idea to add a system property or something similar which allows activation of the old directory structure detection for Gradle <= 3. > It also may be a good idea to not hard-code the "java" sub-directory because the value might be different depending on the plugins used to run and build in Gradle. See the Gradle API doc for [SourceDirectorySet.outputdir|https://docs.gradle.org/4.0/dsl/org.gradle.api.file.SourceDirectorySet.html] which shows how Gradle now creates the output path dynamically. -- This message was sent by Atlassian JIRA (v6.4.14#64029)