Mailing-List: contact commits-help@tomee.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@tomee.apache.org
Date: Tue, 15 Aug 2017 06:39:00 +0000 (UTC)
From: "Romain Manni-Bucau (JIRA)" <jira@apache.org>
To: commits@openejb.apache.org
Message-ID: <JIRA.13094595.1502744557000.31688.1502779140063@Atlassian.JIRA>
In-Reply-To: <JIRA.13094595.1502744557000@Atlassian.JIRA>
References: <JIRA.13094595.1502744557000@Atlassian.JIRA> <JIRA.13094595.1502744557884@jira-lw-us.apache.org>
Subject: [jira] [Commented] (TOMEE-2114) Collection added to itself
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 15 Aug 2017 06:39:04 -0000


    [ https://issues.apache.org/jira/browse/TOMEE-2114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16126860#comment-16126860 ] 

Romain Manni-Bucau commented on TOMEE-2114:
-------------------------------------------

Looks accurate. This method is not supposed to be called but doesnt cost much to fix it.

> Collection added to itself
> --------------------------
>
>                 Key: TOMEE-2114
>                 URL: https://issues.apache.org/jira/browse/TOMEE-2114
>             Project: TomEE
>          Issue Type: Bug
>            Reporter: JC
>            Priority: Trivial
>
> Hi
> In a recent github mirror, I've found suspicious code.
> Branch: master
> Path: container/openejb-core/src/main/java/org/apache/openejb/util/PropertiesService.java
> {code:java}
>  42     private final Properties props = new Properties();
> ...
>  91     public void putAll(final Properties props) {
>  92         props.putAll(props);
>  93     }
> {code}
> In Line 92,  props.putAll should be this.props.putAll? This might not be an issue but I wanted to report just in case.
> Thanks!


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)