Return-Path: X-Original-To: apmail-openejb-commits-archive@www.apache.org Delivered-To: apmail-openejb-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1E693DAE9 for ; Wed, 28 Nov 2012 14:50:54 +0000 (UTC) Received: (qmail 81065 invoked by uid 500); 28 Nov 2012 14:50:53 -0000 Delivered-To: apmail-openejb-commits-archive@openejb.apache.org Received: (qmail 81027 invoked by uid 500); 28 Nov 2012 14:50:53 -0000 Mailing-List: contact commits-help@openejb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@openejb.apache.org Delivered-To: mailing list commits@openejb.apache.org Received: (qmail 81012 invoked by uid 99); 28 Nov 2012 14:50:53 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 28 Nov 2012 14:50:53 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 28 Nov 2012 14:50:51 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id 4E91E238896F; Wed, 28 Nov 2012 14:50:30 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1414734 - /openejb/trunk/openejb/server/openejb-client/src/test/java/org/apache/openejb/client/StickyConnectionStrategyIteratorTest.java Date: Wed, 28 Nov 2012 14:50:29 -0000 To: commits@openejb.apache.org From: andygumbrecht@apache.org X-Mailer: svnmailer-1.0.8-patched Message-Id: <20121128145030.4E91E238896F@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: andygumbrecht Date: Wed Nov 28 14:50:28 2012 New Revision: 1414734 URL: http://svn.apache.org/viewvc?rev=1414734&view=rev Log: Fix test. Should not be checking order and only unique finds. Modified: openejb/trunk/openejb/server/openejb-client/src/test/java/org/apache/openejb/client/StickyConnectionStrategyIteratorTest.java Modified: openejb/trunk/openejb/server/openejb-client/src/test/java/org/apache/openejb/client/StickyConnectionStrategyIteratorTest.java URL: http://svn.apache.org/viewvc/openejb/trunk/openejb/server/openejb-client/src/test/java/org/apache/openejb/client/StickyConnectionStrategyIteratorTest.java?rev=1414734&r1=1414733&r2=1414734&view=diff ============================================================================== --- openejb/trunk/openejb/server/openejb-client/src/test/java/org/apache/openejb/client/StickyConnectionStrategyIteratorTest.java (original) +++ openejb/trunk/openejb/server/openejb-client/src/test/java/org/apache/openejb/client/StickyConnectionStrategyIteratorTest.java Wed Nov 28 14:50:28 2012 @@ -21,8 +21,6 @@ import org.junit.Test; import java.net.URI; import java.util.ArrayList; -import java.util.Arrays; -import java.util.List; /** * @version $Rev$ $Date$ @@ -62,28 +60,29 @@ public class StickyConnectionStrategyIte Assert.assertEquals(uri, iterable.iterator().next()); } -// assertIteration(uris, iterable); + assertIteration(uris, iterable); } private void assertIteration(URI[] uris, Iterable iterable) { - List found = new ArrayList(); + ArrayList found = new ArrayList(); for (URI uri : iterable) { - found.add(uri); + if (!found.contains(uri)) found.add(uri); } Assert.assertEquals(uris.length, found.size()); + for (URI uri : uris) { Assert.assertTrue(found.contains(uri)); } - Assert.assertTrue("Found: " + found + ", Expected: " + Arrays.asList(uris), - found.get(0).equals(uris[0]) && - found.get(1).equals(uris[1]) && - found.get(2).equals(uris[2]) && - found.get(3).equals(uris[3]) - ); +// Assert.assertTrue("Found: " + found + ", Expected: " + Arrays.asList(uris), +// found.get(0).equals(uris[0]) && +// found.get(1).equals(uris[1]) && +// found.get(2).equals(uris[2]) && +// found.get(3).equals(uris[3]) +// ); }