tomee-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Blevins (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OPENEJB-1783) Sometimes the list of URLs is too large when searching for annotated classes.
Date Mon, 20 Feb 2012 19:33:34 GMT

    [ https://issues.apache.org/jira/browse/OPENEJB-1783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212033#comment-13212033
] 

David Blevins commented on OPENEJB-1783:
----------------------------------------

Let's call the util calls UrlSets for consistency and s/cull/exclude/.

Note that the default.exclusions doesn't use regexs, so we can't use that to exclude ".*/Library/Java.*".
 The previous version of the code did use regexs and turned out to be many times slower. 
The cost of the excludes practically erased the benefit from a pure speed perspective.

                
> Sometimes the list of URLs is too large when searching for annotated classes.
> -----------------------------------------------------------------------------
>
>                 Key: OPENEJB-1783
>                 URL: https://issues.apache.org/jira/browse/OPENEJB-1783
>             Project: OpenEJB
>          Issue Type: Bug
>            Reporter: Alan Cabrera
>            Assignee: Alan Cabrera
>             Fix For: 4.0, 4.0.0-beta-3
>
>         Attachments: urls.diff
>
>
> There's no need to search the Java libraries and OpenEJB jars for user CLI extensions.
 Some of the system jars are *huge* and causes an OOM error when scanning is performed.
> Create {{URLs.cullSystemAndOpenEJBJars(urls)}} and {{URLs.cullSystemJars(urls)}} which
can be shared by other bits of code which seem to be cookie cutting this logic.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message