tomee-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jarek Gawor (JIRA)" <j...@apache.org>
Subject [jira] Reopened: (OPENEJB-918) transaction logging is too intrusive by default
Date Thu, 13 Nov 2008 23:14:44 GMT

     [ https://issues.apache.org/jira/browse/OPENEJB-918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jarek Gawor reopened OPENEJB-918:
---------------------------------


I'm pretty sure these changes cause the following errors:

java.util.concurrent.ExecutionException: java.lang.IllegalArgumentException: can't parse argument
number
        at java.util.concurrent.FutureTask$Sync.innerGet(FutureTask.java:205)
        at java.util.concurrent.FutureTask.get(FutureTask.java:80)
        at org.apache.openejb.util.Memoizer.compute(Memoizer.java:53)
        at org.apache.openejb.util.Logger.formatMessage(Logger.java:185)
        at org.apache.openejb.util.Logger.error(Logger.java:276)

The logging was changed to pass parameters instead of doing string concatenation. E.g. log.error("my
exception: " + exception) was changed to log.error("my exception {}", exception). The "{}"
substitution works when using slf4j but not with OpenEJB logger. OpenEJB logger uses MessageFormater
to perform parameter substitution and that requires "{<n>}" format. So I think either
the logging messages need to be fixed or the OpenEJB logger needs to be updated to handle
the "{}" substitution (without the parameter number). 


> transaction logging is too intrusive by default
> -----------------------------------------------
>
>                 Key: OPENEJB-918
>                 URL: https://issues.apache.org/jira/browse/OPENEJB-918
>             Project: OpenEJB
>          Issue Type: Improvement
>          Components: server
>    Affects Versions: 3.1
>            Reporter: David Jencks
>            Assignee: David Jencks
>             Fix For: 3.1
>
>
> The txLogger logs stuff at at least info.  While its good having a separate logger for
production data it is too intrusive to have to turn down this to debug to not clog up logs.
 The logging can also use the format methods to simplify the code a bit.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message