tomee-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "karan singh malhi (JIRA)" <j...@apache.org>
Subject [jira] Updated: (OPENEJB-624) Extract Logger Categories to a separate interface
Date Sun, 05 Aug 2007 11:58:53 GMT

     [ https://issues.apache.org/jira/browse/OPENEJB-624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

karan singh malhi updated OPENEJB-624:
--------------------------------------

    Attachment: openejb-624.patch

Fixed this issue. However, javadoc still needs to be added for each Logger Category.

> Extract Logger Categories to a separate interface
> -------------------------------------------------
>
>                 Key: OPENEJB-624
>                 URL: https://issues.apache.org/jira/browse/OPENEJB-624
>             Project: OpenEJB
>          Issue Type: Improvement
>          Components: general
>            Reporter: karan singh malhi
>            Priority: Minor
>         Attachments: openejb-624.patch
>
>
> If the logger names could be extracted to constants in an interface,
> then it will be easier to make changes to logger names and will also
> lead to lesser errors , because logger names are case sensitive
> So for example, instead of obtaining a logger like
>    public static final Logger logger =
> Logger.getInstance("OpenEJB.startup",
> Assembler.class.getPackage().getName());
> We could do something like
>    public static final Logger logger =
> Logger.getInstance(LogCategory.OPENEJB_STARTUP,
> Assembler.class.getPackage().getName());
> In fact, with static import it will just be
>   public static final Logger logger =
> Logger.getInstance(OPENEJB_STARTUP,
> Assembler.class.getPackage().getName());
> LogCategory would contain the names of all loggers used in openejb.
> Since there are just a few loggers, they could be defined within the
> Logger class itself.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message