From users-return-264646-archive-asf-public=cust-asf.ponee.io@tomcat.apache.org Wed May 2 14:30:49 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id D4CF018065D for ; Wed, 2 May 2018 14:30:48 +0200 (CEST) Received: (qmail 13426 invoked by uid 500); 2 May 2018 12:30:47 -0000 Mailing-List: contact users-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Users List" Delivered-To: mailing list users@tomcat.apache.org Received: (qmail 13415 invoked by uid 99); 2 May 2018 12:30:46 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 May 2018 12:30:46 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 86C8D1A1B6D for ; Wed, 2 May 2018 12:30:46 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.899 X-Spam-Level: * X-Spam-Status: No, score=1.899 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd2-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id ms6Gf6JFYb08 for ; Wed, 2 May 2018 12:30:45 +0000 (UTC) Received: from mail-it0-f44.google.com (mail-it0-f44.google.com [209.85.214.44]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id ECF785F1F0 for ; Wed, 2 May 2018 12:30:44 +0000 (UTC) Received: by mail-it0-f44.google.com with SMTP id z6-v6so13312908iti.4 for ; Wed, 02 May 2018 05:30:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=fSTPPtXAjkYR/M0YKYcnUVt0rXi24NbZE+hHr3Wx4bE=; b=aWLXPVKponntx9Tbuo6cvmPVNsiDXx5QEE9lAylUaLuht2biTGgMsbgMxgCB1URAS+ PEIRLXIJQ0Y5aEJHlV//DaWz4myPShlSBssUTDfZpK2+RGNCd6RbSpMNIiknh0C95ru0 UCU0DvgLNhOO/9m8TvhgfeLVFjo9GNHWRx4kHFDG5R+JBQ9cErSymL8HTkkSyzHSRo7B ie5q7xOvYsikKbGui4pcVCe2h17Ack/uOiuuYKI8OcN6uaCbCvHXe+H+miTrVLDrA8lb WU9/Z9rX3uuNud2Wzh6eydzwkfxT4pCgo1OXSuFCAjPfJNMNjfc5bv85yzwHBDSyZpBy SPyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=fSTPPtXAjkYR/M0YKYcnUVt0rXi24NbZE+hHr3Wx4bE=; b=e3U8LJmAMrrLfa+CY9zZbbrVXlIplvSAvYVUoL9ORj4BaEuqoMlhQdadkH3POdSHod 2MdHibOYXPg08d3lpndMzRyrXbsnzi2kohjuM0tQoeWSmqTsPBvyq7z2qJMbyk+gs7gW MzIeSMGf3Cv+BZK5u+p5WJ/esXknaaIIpZDIF5+dxsVheBYkCoK0Bz048yrFxjyJxuan QcvHkwYj3k57YggnDttEV47PwLFQRWTEI8VYLeM4Q/GPZ5FD9v79yCSES4QPuFNSLQNN b9edeEnPhjC88xq0oxiP8y7FKolOeLurdVz3gFwCGXWGtdW2qcsgnshmVFU8fKPWzCnF lRIw== X-Gm-Message-State: ALQs6tA0YQ2OrnjCeGcyrTQm5YAbygOYLZyO+yW4LEO2O7TMI1jy88/o FGeKNE18QmO9idpyND3AokoJvufL9RHl2R1rMQk= X-Google-Smtp-Source: AB8JxZqxk5xiygbZzc3BXIuzSIn5E8TWZrevy7D1VsSmfQeVEWCzjl6P7Cu+IHPchytjkV4LY4LQ2JmEBZWqfAZYe5g= X-Received: by 2002:a24:91ce:: with SMTP id i197-v6mr20457148ite.116.1525264243958; Wed, 02 May 2018 05:30:43 -0700 (PDT) MIME-Version: 1.0 References: <1aea399a-54bd-fb14-cca5-32d010e430d1@apache.org> In-Reply-To: <1aea399a-54bd-fb14-cca5-32d010e430d1@apache.org> From: "M. Manna" Date: Wed, 02 May 2018 12:30:33 +0000 Message-ID: Subject: Re: Jsp pages with scriptlet and javadoc comments loaded in char[] To: Tomcat Users List Content-Type: multipart/alternative; boundary="0000000000007328bc056b384156" --0000000000007328bc056b384156 Content-Type: text/plain; charset="UTF-8" Hi Mark, Basically, our application has quite a lot of large objects which are singletons. When we checked the list of char[] objects loaded in the memory, some of them showed JspServlet related Strings and had commented code loaded into char[]. we have quite a lot of Strings loaded in memory (using maps) which are necessary. heap-dump will always report this as a memleak but it's not - So trying to understand whether we can utilise anything from tomcat side to remove I understand it sounds odd, but at that point it appeared to be something we can just strip out. But from your comments, it doesn't seem to be an option. Thanks, On 2 May 2018 at 10:39, Mark Thomas wrote: > On 02/05/18 10:31, M. Manna wrote: > > Hi All, > > > > I had a specific question regarding JSPs loaded in web-application > > container for jasper to compilation. If I have a JSP page which has > > scriptlet and javadoc comments/code comments, aren't those loaded into > the > > char[] of JSP pages too? > > No. > > > I understand that Jasper compiles the JSPs but > > those comments aren't stripped out (apologies if I have missed something > in > > source code). I am using tomcat 8.5.28. > > Yes, they are. HTML comments (which are essentially template text) are not. > > > In other words, by cutting down all javadoc comments/commented code from > > JSP scriptlets, can I assume some savings will be made in terms of char[] > > memory size when my servers are very busy? I have about ~3k JSP pages > with > > a mixture of nice clean JSPs and really messy scriptlets. And I am trying > > to find some options to tune GC and see if reducing char[] sizes can help > > me in any way. > > Seems like an odd way to tune GC. What problem are you trying to solve? > > Mark > > --------------------------------------------------------------------- > To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org > For additional commands, e-mail: users-help@tomcat.apache.org > > --0000000000007328bc056b384156--