tomcat-users mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Christopher Schultz <ch...@christopherschultz.net>
Subject Re: database pool and minIdle support in 8
Date Fri, 02 Feb 2018 03:57:21 GMT
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Pawel,

On 2/1/18 6:08 PM, Pawel Veselov wrote:
> On Thu, Feb 1, 2018 at 1:02 PM, Mark Thomas <markt@apache.org>
> wrote:
>> On 01/02/18 20:57, Pawel Veselov wrote:
>>> Hello.
>>> 
>>> It looks like in tomcat 8 (looking at master's HEAD), the
>>> minIdle support is broken. According to docs, minIdle supposed
>>> to do : "The minimum number of established connections that
>>> should be kept in the pool at all times. The connection pool
>>> can shrink below this number if validation queries fail."
>>> 
>>> I see that pool cleaner thread checks if the minIdle is *less*
>>> than pool size, and only then invokes checkIdle(). checkIdle()
>>> then will remove(!) connections from idle pool until the value
>>> drops down to minIdle. But I don't see any code that will add
>>> connections when minIdle is not met, and the documentation
>>> suggests that that's the intent.
>>> 
>>> Am I misunderstanding something? Is there a way to keep a level
>>> of connections in the pool? I don't want to have initialSize
>>> control that, as I need to at 0, to prevent failures during
>>> pool initialization...
>> But that is what initial size is for.
> 
> Indisputably so. However, that would be the only other way to
> achieve this, as long as the database connection don't die.

What is the problem with failures during pool initialization? If you
don't want the pool to make initialSize connections when it starts,
when DO you want the pool to create those connections? During the
first "cleaning"?

- -chris
-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - http://gpgtools.org
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAlpz4aEACgkQHPApP6U8
pFjD4Q/6AsiZtzCvnHESmIyj3a7kxsgioTu5hQ8cZdHHBQGHQ/wDDsTX0Ln+8sAk
yzb+K+PZKTR8Ecv5H3GAn04zwcawq/h8qvhzmM2gn3auE9HZq6I/CqimRcYwjQ3b
ASP/zfAIbAa6dP2+YvX9aaGtsFl8osBDbFz8aKxH5ceNV0GEf2fCUgVZlUev7voS
9cv6fGcCcp/Uyw6VTszUL5MEImnXmte8Mu9/kZ8NejTL9OmqBsun3m/gUXgta2IH
3YsZIEkAr8JO9Zm4LgCgOpBHr2b8nI82rXJc1/j1DZACTwoMhbQM4QkbBb0qpH1x
BKTGDXYdOVF32U0hok1U4AluWwq9Zy9rexIOnGALU7xVYnKGuO7mP85ObJ/GH41F
pCzIXCm39NEizO2bHRSsSeJjNkIiGa3ettuBVojL1YAw6I/ZL1dtfgkSA4ZEh3Vm
jZxCxvopZsxSNbk6YwbscGaG7u+yd0dXywHzJZMsFG/IuFB3LJsTroKJtYTcDz5o
0xTfpWpruGaT5K2U5v5pcVMG7RL4o0Ez/CBZCSj/+eEtvreoAQDyeS9mMN0Hf2KZ
nI84kObsJeZaZLZpnaxbXfXF8jdG0DlF/6A/HyMURo29mkoa0iUYY4JT2fw4HEcD
ZyVNlzANv2GgzSYbH6fCcr/OUFiMZBokdlnmQSR69XNDGrTus24=
=drot
-----END PGP SIGNATURE-----

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org
For additional commands, e-mail: users-help@tomcat.apache.org


Mime
View raw message