Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 554F1200D44 for ; Mon, 20 Nov 2017 15:24:13 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 53976160BF9; Mon, 20 Nov 2017 14:24:13 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 9C0C6160BEC for ; Mon, 20 Nov 2017 15:24:12 +0100 (CET) Received: (qmail 76384 invoked by uid 500); 20 Nov 2017 14:24:11 -0000 Mailing-List: contact users-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Users List" Delivered-To: mailing list users@tomcat.apache.org Received: (qmail 76373 invoked by uid 99); 20 Nov 2017 14:24:11 -0000 Received: from mail-relay.apache.org (HELO mail-relay.apache.org) (140.211.11.15) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 20 Nov 2017 14:24:11 +0000 Received: from Christophers-MacBook-Pro.local (pool-173-66-116-184.washdc.fios.verizon.net [173.66.116.184]) by mail-relay.apache.org (ASF Mail Server at mail-relay.apache.org) with ESMTPSA id C82A01A0140 for ; Mon, 20 Nov 2017 14:24:10 +0000 (UTC) Subject: Re: Supported callbacks in Tomcat JASPIC implementation To: users@tomcat.apache.org References: <421788f5-a2b6-89fb-11d8-6d9aaf30ee99@apache.org> From: Christopher Schultz Message-ID: Date: Mon, 20 Nov 2017 09:24:09 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <421788f5-a2b6-89fb-11d8-6d9aaf30ee99@apache.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit archived-at: Mon, 20 Nov 2017 14:24:13 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Mark and Lazar, On 11/18/17 10:05 AM, Mark Thomas wrote: > On 18/11/17 14:20, Lazar Kirchev wrote: >> Hello Marc, >> >> Do you think it makes sense to make the CallbackHandler >> implementation class configurable, e.g. to be able to specify its >> name via a property? > > As a property on the authenticator? I don't see why not. +1 Also, we should arrange to allow for multiple callback handlers to be supported. >> In this way if support for additional callbacks is necessary >> someone could plug a custom CallbackHandler providing such a >> support. The current CallbackHandlerImpl would remain the default >> one. >> >> Regarding jaspic, as I played around a little bit with it I found >> the following small problems (all bugzilla issues contain also a >> pull request with a patch proposal): Fantastic! Thanks for your contributions! - -chris -----BEGIN PGP SIGNATURE----- Comment: GPGTools - http://gpgtools.org Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAloS5YkACgkQHPApP6U8 pFgznxAAl7+ujEV0K520FcIckJFnz8qLnoTRBz5qlCVFJOBAUVBbNL9zJTUs/n6K /EOVEWmvB26reIvyxprw9UXbhtanukpmYrQ6DWpPsH03z6WIQJhmZ4BXw+XJklJS YE2A3GldT0+wgArSM00bHjDR6gZaHPuTutO9Gpk0su9uw1Erd41dNj53tYqQ9254 pNqhS+tsI8ayQ7zMrNHIzR/C/beS3IOURyyAxHL7wGMGBq83O6+l8u0tTzR5+j0t vFLHa1Q6uVAkofJmOzXehBbX3k7wU6HQdSIXZWcEG8Qhn6i8sjfXJw8cRf7YOIYY Ou5smdWPWEcnQlYDIUwyMx6+/yXhgUgV6chai+tFsNBLlMjNBCjhVmqXB1Jc9kPK fRo6KmcPTaCBip5qk4QdtenY7/5Swi+y9SFKu4AXTxsWx2MvVO/Xupp3RsYocybT 8V8UNmTGbxgRUMyFLjCFN5rPwt6OvgCPle99rMJXtWObGZFdiVL7RhLhoh9mXl8D tUyATSWG+etqn6xn5VlnI9si10hvPcgkWfPn+nEIEWQAbjoi5UP0f2BaFdk3mX8+ t+m+AKup3eiHlSxI/YCwotSQ6+3W7AuSPsZ+O31AFAid54zkw7ZUGniYC4w5wwtq oxIrCOJAmWGbIWotCNlqTm8liV9FhtpzYkNvG/eFIxv9rtsuYm4= =McTq -----END PGP SIGNATURE----- --------------------------------------------------------------------- To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org For additional commands, e-mail: users-help@tomcat.apache.org