Mailing-List: contact users-help@tomcat.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tomcat Users List" <users@tomcat.apache.org>
To: Tomcat Users List <users@tomcat.apache.org>
From: =?UTF-8?Q?Andr=c3=a9_Warnier_=28tomcat=29?= <aw@ice-sa.com>
Subject: Suggested doc change for Connectors
Message-ID: <587F52DE.9000808@ice-sa.com>
Date: Wed, 18 Jan 2017 12:34:54 +0100
User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:38.0) Gecko/20100101
 Thunderbird/38.5.0
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
archived-at: Wed, 18 Jan 2017 11:35:09 -0000

Hi.

This is a partial recap of the theme discussed on the list, in this thread :
http://marc.info/?l=tomcat-user&m=148473249120783&w=2

I would sugest a documentation change, basically in all pages related to Connector's 
configurations, from 9.0, and I believe all the way back to 6.0.

The change relates to the "minSpareThreads" attribute of the Connectors, such as
http://tomcat.apache.org/tomcat-7.0-doc/config/http.html

and the suggestion is based on :
http://tomcat.apache.org/migration-6.html#Connector_thread_pools

Basically, each of the Connector pages repeats the same text about this attribute :

quote

minSpareThreads	

The minimum number of threads always kept running. If not specified, the default of 10 is 
used. If an executor is associated with this connector, this attribute is ignored as the 
connector will execute tasks using the executor rather than an internal thread pool. Note 
that if an executor is configured any value set for this attribute will be recorded 
correctly but it will be reported (e.g. via JMX) as -1 to make clear that it is not used.

unquote

So,
- if there is an Executor, then this Connector attribute is ignored
- but according to the above migration guide, if there is no Executor, it is also ignored.

So basically, why have it ?

Of course, I don't know if there is some deeper code reason to keep mentioning it in the 
Connectors' documentations.  Which is why this is a suggestion.

Maybe instead, it could be made clearer that if there is no Executor, the number of 
threads associated to a Connector may keep on growing over time, up to the maxThreads 
value, and never go down again.
(And the nefarious/beneficial/neutral effects thereof ?)


---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org
For additional commands, e-mail: users-help@tomcat.apache.org