Mailing-List: contact users-help@tomcat.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tomcat Users List" <users@tomcat.apache.org>
MIME-Version: 1.0
References: <CAOqetn_oOsnknOd4SvSxrVqFR59Rh2Cga2nopa_i06T7VrksrA@mail.gmail.com>
 <f0b18bcc-dc70-f296-d587-d4646978e9c1@christopherschultz.net>
 <CAOqetn-wBrGcwRZT-OA82RvXK1LWH=8Jnm7OQ=aeZhXXLuLn7g@mail.gmail.com>
 <CAOqetn9nmMb9F3zXPLM5JBW1qLrRuEH=BZOPSq-vGQbuRS79rQ@mail.gmail.com>
 <ac9edf8c-c3e2-3297-7fcf-06d4e1cfae59@apache.org> <CAOqetn-=sv9TT1JqqCgBJc2CghhUbJxhrPxq1g30oYr6f1t64w@mail.gmail.com>
 <f59cf439-1412-6b8f-4e93-ab487a750270@apache.org> <CAOqetn_+wMKBFPf=9tjxOgwQc5rprvoSm58h3g-qsjVuE+oyKQ@mail.gmail.com>
 <bb1d2075-26f1-4d53-e82a-9dbb7d8a1669@christopherschultz.net>
 <0abce85f-d136-5e53-b3b0-515f7b351df5@apache.org> <e2190577-d58a-c065-f49f-620960f65b3a@christopherschultz.net>
 <b091726e-f9fd-a075-b8c4-bc1d919fb0e6@apache.org>
In-Reply-To: <b091726e-f9fd-a075-b8c4-bc1d919fb0e6@apache.org>
From: "John D. Ament" <johndament@apache.org>
Date: Thu, 15 Dec 2016 03:01:09 +0000
Message-ID: <CAOqetn9_OdYUQVDOr6vshJh3McRo2ufGQ7sg6GtX8UL52naOEQ@mail.gmail.com>
Subject: Re: [OT] Tomcat listener not coming up - no stuck threads
To: Tomcat Users List <users@tomcat.apache.org>
Content-Type: multipart/alternative; boundary=001a114231deea1b7a0543a9aa62
archived-at: Thu, 15 Dec 2016 03:01:28 -0000

--001a114231deea1b7a0543a9aa62
Content-Type: text/plain; charset=UTF-8

I was feeling ambitious so I gave this a shot.  Here's what I changed:
https://github.com/johnament/tomcat85/commit/a0281b2d4e0fea7cb0f7a9d3cd1e750b48498ff2
.
I get some failed tests, but generallys eems good (I broke it earlier, and
lots of things failed).

   [concat] Testsuites with failed tests:
   [concat]
TEST-org.apache.catalina.session.TestStandardSessionIntegration.NIO.txt
   [concat]
TEST-org.apache.catalina.session.TestStandardSessionIntegration.NIO2.txt
   [concat]
TEST-org.apache.catalina.startup.TestHostConfigAutomaticDeployment.NIO.txt
   [concat]
TEST-org.apache.catalina.startup.TestHostConfigAutomaticDeployment.NIO2.txt
   [concat]
TEST-org.apache.catalina.tribes.group.TestGroupChannelMemberArrival.NIO.txt
   [concat]
TEST-org.apache.catalina.tribes.group.TestGroupChannelMemberArrival.NIO2.txt
   [concat]
TEST-org.apache.catalina.tribes.group.TestGroupChannelStartStop.NIO.txt
   [concat]
TEST-org.apache.catalina.tribes.group.TestGroupChannelStartStop.NIO2.txt
   [concat]
TEST-org.apache.catalina.tribes.group.interceptors.TestOrderInterceptor.NIO.txt
   [concat]
TEST-org.apache.catalina.tribes.group.interceptors.TestOrderInterceptor.NIO2.txt
   [concat]
TEST-org.apache.catalina.tribes.group.interceptors.TestTcpFailureDetector.NIO.txt
   [concat]
TEST-org.apache.catalina.tribes.group.interceptors.TestTcpFailureDetector.NIO2.txt
   [concat]
TEST-org.apache.tomcat.util.net.openssl.ciphers.TestCipher.NIO.txt
   [concat]
TEST-org.apache.tomcat.util.net.openssl.ciphers.TestCipher.NIO2.txt
   [concat]
TEST-org.apache.tomcat.util.net.openssl.ciphers.TestOpenSSLCipherConfigurationParser.NIO.txt
   [concat]
TEST-org.apache.tomcat.util.net.openssl.ciphers.TestOpenSSLCipherConfigurationParser.NIO2.txt


I'm wondering, can I publish local maven artifacts using the ant build?
Would be good to see if this fixes or changes my behavior.

John

On Wed, Dec 14, 2016 at 12:22 PM Mark Thomas <markt@apache.org> wrote:

> On 14/12/2016 16:23, Christopher Schultz wrote:
> > Mark,
> >
> > On 12/8/16 4:19 AM, Mark Thomas wrote:
> >> On 07/12/2016 15:21, Christopher Schultz wrote:
> >>>
> >>> Hmm... there is the "startStopThreads" setting on the Engine,
> >>> but unfortunately there is not (currently available) setting that
> >>> says "don't use multiple threads at all". It looks like Tomcat is
> >>> always going to use at least one (separate) thread to launch the
> >>> various Hosts (and webapps).
> >
> >> It wouldn't be too hard to change that to not use an executor if
> >> the default of startStopThreads="1" was being used.
> >
> > +1 to running start on the main thread if startStopThreads="1".
> >
> > Where would I look to start working on a proposed patch? The Tomcat
> > Lifecycle isn't my strong suit.
>
> ContainerBase. Look for uses of startStopThreads.#
>
> >> However...
> >
> > Even if this doesn't solve John's problem, I think it's worth doing.
> >
> > Comments?
>
> No objections. I'd thought about it previously but it wasn't an itch I
> felt the urge to scratch.
>
> Mark
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: users-help@tomcat.apache.org
>
>

--001a114231deea1b7a0543a9aa62--